Closed Bug 1329300 Opened 3 years ago Closed 3 years ago

Crash in IPCError-browser | ShutDownKill | I422ToARGBRow_C

Categories

(Core :: Graphics, defect, P3, critical)

x86
Windows 7
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- wontfix
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: milan, Assigned: sotaro)

References

(Blocks 2 open bugs)

Details

(Keywords: crash, Whiteboard: [gfx-noted])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-c075e0ad-be01-41a5-b71a-e1c432170103.
=============================================================

In ConvertYCbCrToRGB32 from CanvasRenderingContext2D::DrawImage.
Sotaro, is this something we know about?
Assignee: nobody → sotaro.ikeda.g
Flags: needinfo?(sotaro.ikeda.g)
Priority: -- → P3
Whiteboard: [gfx-noted]
It looks similar to Bug 1329305 comment 2.
(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> It looks similar to Bug 1329305 comment 2.

The problem seems to happen, if the content process takes too long to shut down.
Flags: needinfo?(sotaro.ikeda.g)
Attachment #8825290 - Flags: review?(nical.bugzilla)
(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> (In reply to Sotaro Ikeda [:sotaro] from comment #2)
> > It looks similar to Bug 1329305 comment 2.
> 
> The problem seems to happen, if the content process takes too long to shut
> down.

There might be a case that TextureClient became invalid already.
Attachment #8825290 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9984082aba42
Update validity check of SharedPlanarYCbCrImage r=nical
https://hg.mozilla.org/mozilla-central/rev/9984082aba42
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Please request Aurora approval on this when you get a chance.
Flags: needinfo?(sotaro.ikeda.g)
Comment on attachment 8825290 [details] [diff] [review]
patch - Update validity check of SharedPlanarYCbCrImage

Approval Request Comment
[Feature/Bug causing the regression]:None
[User impact if declined]:firefox could crash during shutdown with video playback
[Is this code covered by automated tests?]:Yes.
[Has the fix been verified in Nightly?]:There's no real STR.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No. Low risk.
[Why is the change risky/not risky?]: I just add extra validity check
[String changes made/needed]: None
Flags: needinfo?(sotaro.ikeda.g)
Attachment #8825290 - Flags: approval-mozilla-aurora?
Comment on attachment 8825290 [details] [diff] [review]
patch - Update validity check of SharedPlanarYCbCrImage

fix possible shutdown hang in gfx, beta52+, should be in b2
Attachment #8825290 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.