1329330 - Remove old pre-tab stub session store code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan Henning [:JanH]]

_restoreWindow() has some code left over from the time we didn't create tab stubs on the Java side that's no longer used.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1329330 - Remove old session store code that's no longer needed.

We've been parsing the session store file and doing the initial tab creation on the Java side for a long time now, so the code to open completely new tabs on the session store side instead of using tab stubs is no longer necessary.

Besides, because of bug 1301160 the on-disk session file is now containing tab IDs as well, so this distinction between tabs read directly from the raw session file and those contained in a session string passed over from the Java UI is no longer available.

Review commit: https://reviewboard.mozilla.org/r/103016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103016/

Comment 2

[Jan Henning [:JanH]]

Not a hard dependency, but it's touching the same code - this patch assumes that bug 1301160 has already landed.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8824730 [details]
Bug 1329330 - Remove old session store code that's no longer needed.

https://reviewboard.mozilla.org/r/103016/#review105270

Comment 4

[Jan Henning [:JanH]]

DXR didn't show anybody else attempting to call this and a search on AMO didn't bring up any obvious candidates, either. Just to be on the safe side, I'm leaving this until after merge day, though.

Comment 5

[Jan Henning [:JanH]]

Plus any potential external consumers still have the option of sending tabdata to be restored via "Session:RestoreRecentTabs".

Comment 6

[Jan Henning [:JanH]]

Comment on attachment 8824730 [details]
Bug 1329330 - Remove old session store code that's no longer needed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103016/diff/1-2/

Comment 7

[Jan Henning [:JanH]]

^^ A rebase just to be on the safe side.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=82968a9d820743291e465e76ae74d10ddaa4260d

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f8704c48e61
Remove old session store code that's no longer needed. r=sebastian

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2f8704c48e61