Closed Bug 1329331 Opened 3 years ago Closed 3 years ago

Consider leaving the Large Allocation process after subsequent navigations

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

Details

Attachments

(2 files)

Currently when entering a Fresh Process through the Large-Allocation header, we stay in this process even once the page which was loaded is left. This is unfortunate, as it means that we cannot clean up that process which is now dedicated to only a single tab.

This patch makes loads which occur within this fresh process other than the initial load leave the process. This should allow us to clean up the process, saving on resources, and avoiding loading pages which don't opt into the Large-Allocation header in a e10s-multi system.
Comment on attachment 8824560 [details] [diff] [review]
Leave the Large-Allocation process after subsequent navigations

This is both a review of the code and of the idea. The goal behind this code would be to make it such that the large-allocation feature exposes as few web pages to e10s-multi bugs as possible, as well as allow for us to clean up these new processes as quickly as possible.
Attachment #8824560 - Flags: review?(bugs)
Comment on attachment 8824560 [details] [diff] [review]
Leave the Large-Allocation process after subsequent navigations

Can we have tests for the case when LA process opens new windows and then some navigation is happening.
Also, is there a test that if LA tab starts to load another LA tab, we end up killing the original LA process and create a new LA process?
If not, please add. I could imagine that might be reasonable common case with games sites.

But yeah, I think the concept makes sense, if LA has only one top level browsing context, we should be able to kill it.
Attachment #8824560 - Flags: review?(bugs) → review+
Blocks: 1331083
This adds some tests for the Large-Allocation changes.

MozReview-Commit-ID: JVM8SxleFe8
Attachment #8826739 - Flags: review?(bugs)
Comment on attachment 8826739 [details] [diff] [review]
Add tests for not leaving the Large-Allocation process when there are other toplevel windows

Isn't there info() for cases like ok(true, "Starting test 6");
Attachment #8826739 - Flags: review?(bugs) → review+
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4269f1d5be36
Leave the Large-Allocation process after subsequent navigations, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ca577abf6b5
Add tests for not leaving the Large-Allocation process when there are other toplevel windows, r=smaug
https://hg.mozilla.org/mozilla-central/rev/4269f1d5be36
https://hg.mozilla.org/mozilla-central/rev/8ca577abf6b5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.