Closed
Bug 1329366
Opened 7 years ago
Closed 7 years ago
Avoid the reuse of the same chunk numbers in classifierHelper.js
Categories
(Toolkit :: Safe Browsing, defect, P3)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: francois, Assigned: dimi)
References
Details
(Whiteboard: #sbv4-m8)
Attachments
(1 file)
When adding more than one URL to a test list, we currently add separate chunks with the same chunk number: http://searchfox.org/mozilla-central/rev/0f254a30d684796bcc8b6e2a102a0095d25842bb/toolkit/components/url-classifier/tests/mochitest/classifierHelper.js#70-76 This abuse of the V2 code is not guaranteed to keep working. We should use different chunk numbers or just stick all of the URLs into the same CHUNKNUM like we do here: http://searchfox.org/mozilla-central/rev/0f254a30d684796bcc8b6e2a102a0095d25842bb/toolkit/components/url-classifier/SafeBrowsing.jsm#352-357
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → dlee
Status: NEW → ASSIGNED
|
Reporter | |
Updated•7 years ago
|
Blocks: safebrowsingv4
|
|
Reporter | |
Comment 1•7 years ago
|
||
Bug 1307604 is going to add another copy of this helper in toolkit/components/url-classifier/tests/browser/classifierHelper.js so we should clean this up too to ensure it doesn't break future callers.
Priority: P2 → P3
|
|
Reporter | |
Updated•7 years ago
|
Whiteboard: #sbv4-m8
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8876652 [details] Bug 1329366 - Avoid the reuse of the same chunk numbers in classifierHelper.js. https://reviewboard.mozilla.org/r/148002/#review152666
Attachment #8876652 -
Flags: review?(francois) → review+
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 5•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd8dea7f3cf4eb00d70bb249ddfb8689d5c52f70&selectedJob=106952719
Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/64a340c2f80a Avoid the reuse of the same chunk numbers in classifierHelper.js. r=francois
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/64a340c2f80a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•