132939 - "zarro bugs found" is no more

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P2)

Description

[Bradley Baetz (:bbaetz)]

The template uses .count, it needs to use .size (line 96ish)

Patch coming.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: patch

I also changed the <p> to <br />, because otherwise we got extra trailing
lines. This makes the 0 bug case look similar to the other cases.

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 75707 [details] [diff] [review]
patch

no xhtml.  see bug 47251

Comment 3

[Bradley Baetz (:bbaetz)]

Attachment: begone xhtml!

Bah. The rest of this file is in xhtml.

Comment 4

[Matthew Tuck [:CodeMachine]]

The bugfix is OK, but I think it's much nicer if there's always a blank line
after the bug count.  It just looks too jammed up with this patch.

Comment 5

[Bradley Baetz (:bbaetz)]

Well, I'm just matching the style we get when bugs are found.

Comment 6

[Bradley Baetz (:bbaetz)]

Oh, and there is a blank line - see teh <br>

Comment 7

[Matthew Tuck [:CodeMachine]]

If there are two styles and you want to make them consistent I don't see why you
should choose the worst one because it was the most common.

And I'm not concerned with what was in the source, I was concerned with what it
looked like in the browsers I tried (N4, M0.9.something).

Comment 8

[Bradley Baetz (:bbaetz)]

If you disagree with the style for > 1 bug, please file a separate bug.

Comment 9

[Matthew Tuck [:CodeMachine]]

I'm all for filing a separate bug, but you made the decision to make it a part
of this bug when you produced a multi-issue patch.  Bolting on independent
changes is not a license to bypass review.

Comment 10

[Dave Miller [:justdave]]

Comment on attachment 75714 [details] [diff] [review]
begone xhtml!

r= justdave x2

Comment 11

[Bradley Baetz (:bbaetz)]

OK, left it as a <p>, and we'll see if anyone complains.

<justdave> feel free to put the <p> back when you check it in if you want

Checked in with that change.