13294 - MLK: Memory leak of 5 bytes -nsBrowserAppCore::OnEndDocumentLoad()

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Bruce Mitchener]

1) char* scheme ends up shadowing itself.
2) it owns the memory it gets from the URL, so it needs to free it.

[W] MLK: Memory leak of 5 bytes from 1 block allocated in PL_strdup
        Distribution of leaked blocks
                 5 bytes from 1 block of 5 bytes (0x097b1200) allocation number
210505
        Allocation location
            malloc         [dbgheap.c:129]
            PL_strdup      [strdup.c:30]
            nsCRT::strdup(char const*) [nsCRT.h:151]
            nsStdURL::DupString(char * *,char *) [nsStdURL.cpp:673]
            nsStdURL::GetScheme(char * *) [nsStdURL.h:99]
            nsBrowserInstance::OnEndDocumentLoad(nsIDocumentLoader *,nsIChannel
*,UINT,nsIDocumentLoaderObserver *) [nsBrowserInstance.cpp:1705]
            nsWebShell::OnEndDocumentLoad(nsIDocumentLoader *,nsIChannel
*,UINT,nsIDocumentLoaderObserver *) [nsWebShell.cpp:3515]
            nsDocLoaderImpl::FireOnEndDocumentLoad(nsDocLoaderImpl *,UINT)
[nsDocLoader.cpp:1228]
            nsDocLoaderImpl::OnStopRequest(nsIChannel *,nsISupports *,UINT,WORD
const*) [nsDocLoader.cpp:1098]
            nsLoadGroup::RemoveChannel(nsIChannel *,nsISupports *,UINT,WORD
const*) [nsLoadGroup.cpp:560]
            nsHTTPChannel::ResponseCompleted(nsIChannel *,UINT)
[nsHTTPChannel.cpp:692]
            nsHTTPResponseListener::OnStopRequest(nsIChannel *,nsISupports
*,UINT,WORD const*) [nsHTTPResponseListener.cpp:260]
            nsOnStopRequestEvent::HandleEvent(void)
[nsAsyncStreamListener.cpp:268]
            nsStreamListenerEvent::HandlePLEvent(PLEvent *)
[nsAsyncStreamListener.cpp:144]
            PL_HandleEvent [plevent.c:509]

Comment 1

[Radha on family leave (not reading bugmail)]

Code modified to use nsXPIDLCString.

Comment 2

[leger]

updating QA Contact for verification