1329453 - Show an appropriate menu item if all Containers are removed

Status: NEW

(Firefox :: Menus, defect, P3)

Description

[Itiel]

Attachment: Square artifact visible if all Containers are removed

STR:
1. Install Nightly
2. Go to about:preferences#containers and remove all Containers from the list
3. Open any page, right click any link
4. Hover "Open Link in New Container Tab"

Actual results:
See attached.

Expected results:
There should be a submenu item called "No containers" or something like that.
The same should be applied in the "List all tabs" menu in the tab tray > New Container Tab.

Comment 1

[Kamil Jozwiak [:kjozwiak]]

Attachment: listAllTabsWorking.png

Thanks for filing the bug ItielMaN! We should definitely add "Manage containers" into the context menu rather than leaving it completely blank.

> The same should be applied in the "List all tabs" menu in the tab tray > New
> Container Tab.

I checked the "List all tabs" dropdown menu under OSX, Win and Ubuntu and I can see the "Mange containers" item being listed [listAllTabsWorking.png attached]. Are you seeing a completely blank submenu? If you are, which platform and fx version were you using?

I also went through all the different access points and made sure we're not leaving this menu's blank:

* File Menu - > New Container Tab - PASSED
* Long press on the new tab "+" button - PASSED
* Open Container Tab via the hamburger menu - PASSED
* list all tabs down arrow -> New Container Tab - PASSED
* right click context menu -> FAILED

Comment 2

[Itiel]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #1)
> I checked the "List all tabs" dropdown menu under OSX, Win and Ubuntu and I
> can see the "Mange containers" item being listed [listAllTabsWorking.png
> attached]. Are you seeing a completely blank submenu? If you are, which
> platform and fx version were you using?

I think having the "Manage containers" item is a bonus (and a good one), but my concern in this bug is with adding a "No containers" item in all the access points you've mentioned.
Having a "Manage containers" item in the right click context menu will actually fix this bug, but I see a translatable string in Pontoon called "No Container" (though I can't see its occurence anywhere in Firefox) that I think should appear on any access point (including in about:preferences#containers), if no all containers are removed.

Comment 3

[Itiel]

Also, in your screenshot you can clearly see a separator that shouldn't be there (well, it should appear if a string such as "No containers" will appear above the "Manage containers")

Comment 4

[Kamil Jozwiak [:kjozwiak]]

> I think having the "Manage containers" item is a bonus (and a good one), but
> my concern in this bug is with adding a "No containers" item in all the
> access points you've mentioned.

Agreed, we should probably add some type of text or an indicator to let users know that there's currently no containers created/available.

The container feature is also slated for the Test Pilot program [1] sometime this quarter so the UI might change depending on the feedback we get. So I'm not if it's worth investing time into the UI until we get more information from the test pilot.. Tanvi, thoughts?

However, we should definitely fix the right click context menu problem.

[1] https://wiki.mozilla.org/Test_Pilot