1329480 - youtube video stops playing shortly after I open it with an error "An error occurred. Please try again later. Playback ID blablabla"

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alice0775 White]

Reproducible: 100% on the certain video (I did not try with other video)

Steps To Reproduce:
1. Open https://www.youtube.com/watch?v=Q_JVEXDrJYg&t=56s
2. Change video resolution to 1080p, (Mime Type: video/webm; codecs="vp9)
3. Wait for a while (until around 1:10 in my case)
   --- observe the bug.
4. Reload the video (Press F5 or open the URL in the same tab)
5. Repeat step3,4,5 if any

Actual Results:
video stops playing shortly after I open it with an error "An error occurred. Please try again later. Playback ID blablabla"

Expected Results:
No error.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=502977d27c2806e7bcaf7703c9f6ae8686912fed&tochange=efb08fa7d183891ab0381cb84f30f2ceaf990f9d

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:  youtube video does not play

Another video 
https://www.youtube.com/watch?v=M6mmv0sGYOM&list=PUxVlUVEiwY43qLhCB7kMBIw 

HTMLMediaElement debug data

https://www.youtube.com/watch?v=M6mmv0sGYOM&list=PUxVlUVEiwY43qLhCB7kMBIw
	blob:https://www.youtube.com/9bcfecbf-cbff-4d56-bf48-2e8c89c315a5
	currentTime: 2.599659 readyState: 3
	Quality: 100% (total:80 dropped:0 corrupted:0)
	Buffered ranges: [(0, 10.001)]
		SourceBuffer 0
			start=0 end=10.007165
		SourceBuffer 1
			start=0 end=10.001
	Internal Data:
	audio decoder: wmf audio decoder
	audio frames decoded: 202
	audio state: ni=0 no=0 ie=0 demuxr:0 demuxq:0 tt:-1.000000 tths:-1 in:203 out:202 qs=1 pending:0 waiting:0 wfk:0 sid:5
	video decoder: ffvpx video decoder
	hardware video decoding: disabled
	video frames decoded: 91 (skipped:0)
	video state: ni=0 no=0 ie=0 demuxr:0 demuxq:0 tt:-1.000000 tths:-1 in:93 out:91 qs=2 pending:0 waiting:0 wfk:0, sid:4
	Dumping data for demuxer d3f64d0:
		Dumping Audio Track Buffer(audio/mp4a-latm): - mLastAudioTime: 4.713356
			NumSamples:431 Size:235549 Evictable:110648 NextGetSampleIndex:203 NextInsertionIndex:431
			Buffered: ranges=[(0.000000, 10.007165)]
		Dumping Video Track Buffer(video/webm; codecs=vp9) - mLastVideoTime: 3.100000
			NumSamples:300 Size:1635486 Evictable:0 NextGetSampleIndex:93 NextInsertionIndex:300
			Buffered: ranges=[(0.000000, 10.001000)]
	

Thd @720p Video stops at around 0:27 0:40 random.

So, any youtube video seems to be affected....

Comment 2

[Alice0775 White]

Attachment: about:support

Comment 3

[Alice0775 White]

video/webm; codecs="vp9" seems to be affected.

Comment 4

[Marcia Knous [:marcia]]

Tracking 53+ as this affects youtube videos.

Comment 5

[Alice0775 White]

wait, the regression range in comment#0 is wrong.

Comment 6

[Alice0775 White]

[Tracking Requested - why for this release]: Video stops with error (especially when reload)

Reproducible: 50/50. almost 100% when reload

Steps To Reproduce:
1. Open https://www.youtube.com/watch?v=M6mmv0sGYOM&list=PUxVlUVEiwY43qLhCB7kMBIw
2. Change resolution 720p, Make sure that mime/type should be video/webm; codecs="vp9".
3. Playback for 1-2minutes. If not reproduce then go to next step4
4. Press F5 to reload page
5. Playback for 1-2minutes. If not reproduce then repeat from step4.

Actual Results: 
 Stops with the error at around 0:26 0:41 random.


And I can reproduce the problem on Aurora52.02[1].
[1] https://hg.mozilla.org/releases/mozilla-aurora/rev/fed81ec38bdf9a6ae80bdbedf5845d0fe84c1c86
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 ID:20170109004008




Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d51a0f8c1c7605e0df7b61fe4c31a3f5ec1fd58f&tochange=f26d5e27e1b69638bb9c0e24a1936f40ac7b40dc

Regressed by: Bug 1314533

Comment 7

[Alice0775 White]

Via local build
Last Good: 33c8e33b0bb0
First Bad: 754c160ecbed

Regressed by: 	754c160ecbed	Jean-Yves Avenard — Bug 1314533: [MSE] P3. Reject invalid MP4 boxes. r=gerald

Comment 8

[Julien Cristau [:jcristau]]

Tracking 52+ for this regression affecting youtube.

Comment 9

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1329480: [MSE] Do not reject partial boxes.

Partial content less than 8 bytes long was incorrectly rejected.

We now assume that content is valid unless it is explicitly incorrect (bad box type)

Review commit: https://reviewboard.mozilla.org/r/104550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104550/

Comment 10

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8826628 [details]
Bug 1329480: [MSE] Do not reject partial boxes.

https://reviewboard.mozilla.org/r/104550/#review105372

r+ as is or with suggestion:

Just a reminder of the power of <algorithm>! (Reminder to self too, I'm thinking I could use that elsewhere...)

::: dom/media/mediasource/ContainerParser.cpp:405
(Diff revision 1)
> -
> +        bool valid = false;
>          for (const auto& boxType : validBoxes) {
>            if (type == boxType) {
> -            mValid = true;
> +            valid = true;
>              break;
>            }
>          }
> -        if (!mValid) {
> +        if (!valid) {

You could replace these 8 lines with:
#include <algorithm>
if (std::find(std::begin(validBoxes), std::end(validBoxes), type) == std::end(validBoxes)) {

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8826628 [details]
Bug 1329480: [MSE] Do not reject partial boxes.

https://reviewboard.mozilla.org/r/104550/#review105372

I don't follow what you mean here

Comment 12

[Jean-Yves Avenard [:jya]]

Comment on attachment 8826628 [details]
Bug 1329480: [MSE] Do not reject partial boxes.

https://reviewboard.mozilla.org/r/104550/#review105372

Oh i see. never mind

Comment 13

[Jean-Yves Avenard [:jya]]

Comment on attachment 8826628 [details]
Bug 1329480: [MSE] Do not reject partial boxes.

https://reviewboard.mozilla.org/r/104550/#review105372

> You could replace these 8 lines with:
> #include <algorithm>
> if (std::find(std::begin(validBoxes), std::end(validBoxes), type) == std::end(validBoxes)) {

I thought the use of the stl was not recommended?

Comment 14

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

There is a list of acceptable and already-used-so-we-might-as-well-make-them-acceptable libraries there, including <algorithm>:
https://dxr.mozilla.org/mozilla-central/source/config/stl-headers

Comment 15

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Relevant blog post by Nathan:
https://blog.mozilla.org/nfroyd/2016/05/31/why-gecko-data-structures-should-be-preferred-to-std-ones/

Comment 16

[Jean-Yves Avenard [:jya]]

Comment on attachment 8826628 [details]
Bug 1329480: [MSE] Do not reject partial boxes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104550/diff/1-2/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37d35f87e0fe
[MSE] Do not reject partial boxes. r=gerald

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/37d35f87e0fe

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this when you get a chance.

Comment 20

[Jean-Yves Avenard [:jya]]

Comment on attachment 8826628 [details]
Bug 1329480: [MSE] Do not reject partial boxes.

Approval Request Comment
[Feature/Bug causing the regression]: 1314533
[User impact if declined]: YouTube decoding error.
[Is this code covered by automated tests?]: YT MSE tests
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: excellent STR provided by OP
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: correcting brainfart.
[String changes made/needed]: none

Comment 21

[Julien Cristau [:jcristau]]

Comment on attachment 8826628 [details]
Bug 1329480: [MSE] Do not reject partial boxes.

fix video playing issue affecting youtube, aurora52+

Comment 22

[Julien Cristau [:jcristau]]

Setting qe-verify+, STR in comment 0.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a53dde9442c8

Comment 25

[Petruta Horea [:phorea], Desktop Test Engineering]

I intermittently reproduced the issue using the url from comment 6 on Nightly 53.0a1 2017-01-08 under Win 10 64-bit.

On Firefox 52 beta 3 (codecs=vp9) and latest Aurora 53.0a2 2017-02-06 (here the codecs value is avc1.4d401f) the issue no longer occurs.