Closed Bug 1329546 Opened 7 years ago Closed 7 years ago

Get rid of CaptivePortalWatcher and unify captive portal tests

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox53 --- affected

People

(Reporter: nhnt11, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxprivacy]) 

After bug 1313568 lands, captive portal frontend code and tests will be found in browser/modules as well as browser/base. We should get rid of CaptivePortalWatcher.jsm and move the relevant tests to browser/base/content/test/captivePortal.

This means that all captive portal logic will be handled per-window, meaning that the logic/UX around portal detection when there is no browser window open, and automatically showing the portal tab when one is opened, will need to be tweaked. Possible new logic: automatically open captive portal tab in a newly opened browser window, if no other browser window exists at the time of opening (and possibly only if it was opened with Cmd/Ctrl+N, i.e. with no URLs to immediately load).
Taking care of this in bug 1313568.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.