1329606 - Improve "Copy" context menu item for new console

Status: RESOLVED DUPLICATE of bug 1307906

(DevTools :: Console, defect)

Description

[Julian Descottes [:jdescottes]]

Bug 1307239 implements most of the existing context menu items for the webconsole, but the copy menu item needs additional work.

The current implementation in the new console simply uses the textContent of the message.
The old console frontend was pre constructing a "clipboardText" information for each console message, adding new lines, formatting etc...

What should be done here:
- compare the output of "copy" between old and new console frontend, for various console messages
- fix the new "copy" menu item to be similar to the old one
- finish implementing devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_context_menu_copy_entire_message.js (or split in several tests)

Comment 1

[Brian Grinstead [:bgrins]]

(In reply to Julian Descottes [:jdescottes] from comment #0)
> Bug 1307239 implements most of the existing context menu items for the
> webconsole, but the copy menu item needs additional work.
> 
> The current implementation in the new console simply uses the textContent of
> the message.
> The old console frontend was pre constructing a "clipboardText" information
> for each console message, adding new lines, formatting etc...

I was wondering if it's worth the time to do this, as opposed to making sure newlines and spacing is properly set up in textContent and then allowing normal copy behavior to work.  It's probably more straightforward to let copy work as in other tools/web pages and just grab what you have highlighted.  Not that this bug should be closed, but that it might be able to be de-scoped and we wouldn't have to worry about browser_webconsole_context_menu_copy_entire_message.js compatibility.

Comment 2

[Julian Descottes [:jdescottes]]

(In reply to Brian Grinstead [:bgrins] from comment #1)
> (In reply to Julian Descottes [:jdescottes] from comment #0)
> > Bug 1307239 implements most of the existing context menu items for the
> > webconsole, but the copy menu item needs additional work.
> > 
> > The current implementation in the new console simply uses the textContent of
> > the message.
> > The old console frontend was pre constructing a "clipboardText" information
> > for each console message, adding new lines, formatting etc...
> 
> I was wondering if it's worth the time to do this, as opposed to making sure
> newlines and spacing is properly set up in textContent and then allowing
> normal copy behavior to work.  It's probably more straightforward to let
> copy work as in other tools/web pages and just grab what you have
> highlighted.  Not that this bug should be closed, but that it might be able
> to be de-scoped and we wouldn't have to worry about
> browser_webconsole_context_menu_copy_entire_message.js compatibility.

Agreed, when I said "similar" I just want to have something "as usable" as before. 
No need for full backward compatibility.

Comment 3

[Julian Descottes [:jdescottes]]

This should be closed as a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1307906