1329621 - test_crypto_random.js attempts to test different key algorithms, but WeaveCrypto no longer supports them

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Banner (:standard8)]

I discovered this whilst cleaning up issues from eslint. test_crypto_random.js at one stage does:

https://dxr.mozilla.org/mozilla-central/rev/d192a99be4b436f2dc839435319f7630d5d8f4b0/services/crypto/tests/unit/test_crypto_random.js#48

```
  cryptoSvc.algorithm = WeaveCryptoModule.AES_256_CBC;
  keydata  = cryptoSvc.generateRandomKey();
  do_check_eq(keydata.length, 44);
  ...
```

However, neither WeaveCryptoModule.AES_256_CBC nor cryptoSvc.algorithm are valid.

Both have been removed, and it looks like the WeaveCrypto service uses just one algorithm.

Therefore that first line is basically a no-op, and the duplicate test can be removed.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1329621 - test_crypto_random.js attempts to test different key algorithms, but WeaveCrypto no longer supports them.

Review commit: https://reviewboard.mozilla.org/r/103286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103286/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8824947 [details]
Bug 1329621 - test_crypto_random.js attempts to test different key algorithms, but WeaveCrypto no longer supports them.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103286/diff/1-2/

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8824947 [details]
Bug 1329621 - test_crypto_random.js attempts to test different key algorithms, but WeaveCrypto no longer supports them.

https://reviewboard.mozilla.org/r/103286/#review103900

Hah. Good catch!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd64a0a38b30
test_crypto_random.js attempts to test different key algorithms, but WeaveCrypto no longer supports them. r=rnewman

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd64a0a38b30