1329670 - Change gfxFont's method CopyWithAntialiasOption to return UniquePtr

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Daniel Holbert [:dholbert]]

The function CopyWithAntialiasOption (on the gfxFont interface) returns a raw pointer to a freshly allocated object (or nullptr). And the one caller stores this returned value in a UniquePtr, here:
  https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxFont.cpp#2308

We should change CopyWithAntialiasOption to simply return UniquePtr.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix (first half): change signature on gfxFont & change callsite to use Move()

I'm splitting this into two parts for easier review (though I'll land it as a single merged changeset so as not to introduce an intermediate point where we don't compile).

Here's the first part -- changing the function signature and the callsite.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix (second half): update implementations in gfxFont's subclasses

...and here's the second part, which updates the implementations.

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8825063 [details] [diff] [review]
fix (second half): update implementations in gfxFont's subclasses

(Note that I'm introducing a local 'auto' variable here, for one of the constructor-args, simply to reduce the length of the MakeUnique<...>(...) line.)

Comment 4

[Daniel Holbert [:dholbert]]

Oh -- side note, in the second half I'm also dropping 'virtual' from the function signature (since I'm touching that line anyway) -- because, per our coding style, that keyword is not supposed to accompany the 'override' keyword (which these subclass function impls have at the end).

Comment 5

[Jonathan Kew [:jfkthame]]

Comment on attachment 8825063 [details] [diff] [review]
fix (second half): update implementations in gfxFont's subclasses

Review of attachment 8825063 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7177f9bb9d93
Change gfxFont::CopyWithAntialiasOption to return UniquePtr instead of raw pointer. r=jfkthame

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7177f9bb9d93