1329689 - QuotaManager: Upgrade loop should also cover "from 0_0 to 1_0" case

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan Varga [:janv]]

We're adding new upgrade methods in other bugs, but I found out that our upgrade loop is buggy. It works fine right now because there are no real upgrade methods in the loop.
The problem is that if storage.sqlite doesn't exist (|if (newDatabase)| branch), we execute all the legacy stuff like upgrading indexedDB/ to storage/, but we don't execute the upgrade loop at all. It means that if we add a new upgrade method to the loop and then someone with an old profile (no storage.sqlite) jumps directly to current Nightly, the new upgrade method won't be executed at all.

I refactored stuff a bit to fix this issue and I also added a small optimization for the case when we have a new profile, in which case we don't have to execute the upgrade loop.

Comment 1

[Jan Varga [:janv]]

Attachment: patch

Comment 2

[Jan Varga [:janv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=188c601d78c0c14c14b423051718622af93b2fb6

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8825093 [details] [diff] [review]
patch

Review of attachment 8825093 [details] [diff] [review]:
-----------------------------------------------------------------

Nice fresh profile optimization!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b93a1c921f66
QuotaManager: Upgrade loop should also cover "from 0_0 to 1_0" case; r=asuth

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b93a1c921f66