1329726 - hook RUST_PROGRAMS and HOST_RUST_PROGRAMS into the compile graph

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

Directories that only have RUST_PROGRAMS don't get added to the compile graph in root-deps.mk, so |mach| thinks there's nothing interesting there.  (I think things work OK if there are other interesting things in the directory to build, but having only RUST_PROGRAMS is probably going to be a common use-case.)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - ensure _compile_graph is deterministically ordered

Future tests will depend on the ordering for this, and it seems like a
good change to make in any event.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - ensure {,HOST_}RUST_PROGRAMS are hooked into root-deps.mk

If we don't do this, a directory with only
RUST_PROGRAMS (resp. HOST_RUST_PROGRAMS) won't get traversed properly.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8825150 [details] [diff] [review]
part 2 - ensure {,HOST_}RUST_PROGRAMS are hooked into root-deps.mk

Review of attachment 8825150 [details] [diff] [review]:
-----------------------------------------------------------------

I should have caught this in the last review, sorry about that. Thank you for adding the test.

::: python/mozbuild/mozbuild/test/backend/test_recursivemake.py
@@ +772,4 @@
>          lines = [l.strip() for l in open(backend_path, 'rt').readlines()[2:]]
>  
>          expected = [
> +            'CARGO_FILE := %s/code/Cargo.toml' % env.topsrcdir,

It looks like an `hg mv` from `Cargo.toml` to `code/Cargo.toml` is missing from this patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cc34e640a62
part 1 - ensure _compile_graph is deterministically ordered; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/479b8c84babf
part 2 - ensure {,HOST_}RUST_PROGRAMS are hooked into root-deps.mk; r=chmanchester

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4cc34e640a62
https://hg.mozilla.org/mozilla-central/rev/479b8c84babf