hook RUST_PROGRAMS and HOST_RUST_PROGRAMS into the compile graph

RESOLVED FIXED in Firefox 53

Status

Firefox Build System
General
RESOLVED FIXED
a year ago
3 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

Trunk
mozilla53
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
Directories that only have RUST_PROGRAMS don't get added to the compile graph in root-deps.mk, so |mach| thinks there's nothing interesting there.  (I think things work OK if there are other interesting things in the directory to build, but having only RUST_PROGRAMS is probably going to be a common use-case.)
(Assignee)

Comment 1

a year ago
Created attachment 8825149 [details] [diff] [review]
part 1 - ensure _compile_graph is deterministically ordered

Future tests will depend on the ordering for this, and it seems like a
good change to make in any event.
Attachment #8825149 - Flags: review?(cmanchester)
(Assignee)

Comment 2

a year ago
Created attachment 8825150 [details] [diff] [review]
part 2 - ensure {,HOST_}RUST_PROGRAMS are hooked into root-deps.mk

If we don't do this, a directory with only
RUST_PROGRAMS (resp. HOST_RUST_PROGRAMS) won't get traversed properly.
Attachment #8825150 - Flags: review?(cmanchester)
Attachment #8825149 - Flags: review?(cmanchester) → review+
Comment on attachment 8825150 [details] [diff] [review]
part 2 - ensure {,HOST_}RUST_PROGRAMS are hooked into root-deps.mk

Review of attachment 8825150 [details] [diff] [review]:
-----------------------------------------------------------------

I should have caught this in the last review, sorry about that. Thank you for adding the test.

::: python/mozbuild/mozbuild/test/backend/test_recursivemake.py
@@ +772,4 @@
>          lines = [l.strip() for l in open(backend_path, 'rt').readlines()[2:]]
>  
>          expected = [
> +            'CARGO_FILE := %s/code/Cargo.toml' % env.topsrcdir,

It looks like an `hg mv` from `Cargo.toml` to `code/Cargo.toml` is missing from this patch.
Attachment #8825150 - Flags: review?(cmanchester) → review+

Comment 4

a year ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cc34e640a62
part 1 - ensure _compile_graph is deterministically ordered; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/479b8c84babf
part 2 - ensure {,HOST_}RUST_PROGRAMS are hooked into root-deps.mk; r=chmanchester

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4cc34e640a62
https://hg.mozilla.org/mozilla-central/rev/479b8c84babf
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.