13298 - MLK: nsProfile::GetProfileDir()

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect, P3)

Description

[Bruce Mitchener]

nsRegistry::GetString() allocates.  Please nsCRT::free() it.

[W] MLK: Memory leak of 4 bytes from 1 block allocated in PR_Malloc
        Distribution of leaked blocks
                 4 bytes from 1 block of 4 bytes (0x072c9fa0) allocation number
82417
        Allocation location
            malloc         [dbgheap.c:129]
            PR_Malloc      [prmem.c:38]
            nsRegistry::GetString(DWORD,char const*,char * *)
[nsRegistry.cpp:521]
            nsProfile::GetProfileDir(char const*,nsFileSpec *)
[nsProfile.cpp:362]
            nsProfile::GetCurrentProfileDir(nsFileSpec *) [nsProfile.cpp:822]
            LocalStoreImpl::Init(void) [nsLocalStore.cpp:328]
            NS_NewLocalStore(nsILocalStore * *) [nsLocalStore.cpp:214]
            RDFFactoryImpl::CreateInstance(nsISupports *,nsID const&,void * *)
[nsRDFFactory.cpp:247]
            nsComponentManagerImpl::CreateInstance(nsID const&,nsISupports
*,nsID const&,void * *) [nsComponentManager.cpp:1203]
            nsComponentManager::CreateInstance(nsID const&,nsISupports *,nsID
const&,void * *) [nsRepository.cpp:77]
            nsServiceManagerImpl::GetService(nsID const&,nsID const&,nsISupports
* *,nsIShutdownListener *) [nsServiceManager.cpp:237]
            nsServiceManagerImpl::GetService(char const*,nsID const&,nsISupports
* *,nsIShutdownListener *) [nsServiceManager.cpp:381]
            nsServiceManager::GetService(char const*,nsID const&,nsISupports *
*,nsIShutdownListener *) [nsServiceManager.cpp:485]
            ServiceImpl::GetDataSource(char const*,nsIRDFDataSource * *)
[nsRDFService.cpp:1023]
            XULDocumentImpl::EndLoad(void) [nsXULDocument.cpp:2066]

Comment 1

[racham]

Will use nsCRT::free(). Started my new builds.

Comment 2

[Alec Flett]

Taking all these bugs to be fixed appropriately.

Comment 3

[Alec Flett]

racham, I'm fixing this for you.
Please look at my checkins and learn how to use nsXPIDLCString.

Comment 4

[Grace Bush]

dev bug

Comment 5

[leger]

Moving all Profile Manager bugs to new Profile Manager Backend component.
Profile Manager component to be deleted.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6bdb4bac9ff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13298 - Make private tabs in tabs tray not long clickable (https://github.com/mozilla-mobile/fenix/pull/13316)