PAPZCTreeManager.ipdl bootlegs the include of TabMessageUtils.h

RESOLVED FIXED in Firefox 53

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

53 Branch
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
While working on bug 1329797, I removed "child opens PBackground" drop PContent.ipdl. Because of that (or maybe some other change, though otherwise I just added or deleted some methods), The codegenned output from PAPZCTreeManager does not compile any more, complaining about a missing ParamTraits for nsEventStatus. The easiest fix is just adding an include of TabMessageUtils.h, which defines the ParamTraits.
(Assignee)

Comment 1

2 years ago
"drop PContent.ipdl" should read "from PContent.ipdl".
Were you going to throw up a patch, or do you want me to? rs=me if you do it! :)
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
Whiteboard: [gfx-noted]
Version: unspecified → 53 Branch
(Assignee)

Comment 3

2 years ago
Yeah, I have a patch, I just hadn't gotten around to uploading it yet.
Comment hidden (mozreview-request)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8825560 [details]
Bug 1329805 - Add in bootlegged include to PAPZCTreeManager.

https://reviewboard.mozilla.org/r/103686/#review104578
Attachment #8825560 - Flags: review?(bugmail) → review+

Comment 6

2 years ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39a1951224a2
Add in bootlegged include to PAPZCTreeManager. r=kats

Comment 7

2 years ago
Patch landed few hours ago https://hg.mozilla.org/mozilla-central/rev/39a1951224a2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.