1329843 - Visually distinguish value from device vs. user override

Status: NEW

(DevTools :: Responsive Design Mode, defect, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Current styling of viewport properties such as:

* Network throttling
* dPR
* Touch simulation

does not make it clear when the value shown is implied by selected device vs. overridden by an explicit user choice.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Additional ideas discussed with :clarkbw include:

* Always change device name to "no device" if you move any properties away from those of the device description
* Add some kind of "revert to device" button to get back to the device you left quickly

:clarkbw said he had some additional thoughts he'd add here.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

One thing I was thinking about was to avoid returning to "no device" whenever possible.  Currently once you change a setting we reset your device choice to "no device" and if I'm interested in testing a single device this is a frustrating experience as I have to continually re-select it after trying out a few changes.

So if this is the selector after first choosing a device:

+---------------------------+
|  iPhone 6s  \/            |
+---------------------------+

If you changed anything, like size or DPR or mouse events it would only change to this:

+---------------------------+
|  iPhone 6s  \/  [*]       |
+---------------------------+

(Where [*] is some kind of "undo icon")

Clicking [*] would revert all changes back to the last selected device.  If you selected a new device at any time all settings from that device would cascade into the other settings; overwriting anything custom you had done.

This prevents the reset to "no device" and allows users to try lots of changes but easily get back to the original.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

We agreed that device properties should all be replaced when changing devices, so deviations from the device would be overwritten.