1329903 - Form autofill options above the footer should scroll when long

Status: NEW

(Toolkit :: Form Autofill, defect, P3)

Description

[Sean Lee [:seanlee][:weilonge]]

Attachment: Case C - The maximum height of the drop down suggestions

Based on the spec [1] (or see it in the attachment), all form fill suggestions will be placed in a scrollable area not including the footer button, "Form Autofill Options...". AFAIK, AutoComplete component does not support it yet.

Since Password Manager has a similar design in bug 1319919 comment 18, we can have a discussion what's the final UX/Visual design and have a implementation discussion to satisfy the both cases at meanwhile.

[1] https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/188574112

Comment 1

[Sean Lee [:seanlee][:weilonge]]

Hi Juwei, Fang,

Could you discuss the footer design with Ryan since both Form Autofill and Contextual Feedback have it? Thanks.

Comment 2

[Juwei Huang[:juwei]]

Hi Ryan!
According to Sean's comment, I would like to know if there's any behaviour definition on the maximum height of the drop down menu from password management? Currently from the form autofill side we define a maximum height for the drop down menu. And if the profiles are overwhelming, we would make the menu scrollable yet the footer (form autofill settings) would stay on the foreground of the menu.
Let me know if you have any updates from your side and we can align the design with each other.
Thanks!!

Comment 3

[Fang Shih [:fang]]

Attachment: FormAutofill-longlist.png

As Juwei mentioned, Here are our current design example.

Comment 4

[Ryan Feeley [:rfeeley]]

Wow, I never thought of this. Users don't typically have too many logins for a site, but in the event they do, this could work well. I think we should definitely offer this and also use the same height size in every respect. Is there a way to make this a style Matt so they can look the same?

Comment 5

[Matthew N. [:MattN]]

The scrolling was too hard to implement so we didn't include that in current autofill scope. If we do implement it we should share it with a base binding.

Comment 6

[ce]

I had originally submitted bug 1590622 to complain about this, though it was ultimately repurposed to address another issue. Since this one already exists i won't make another, but i will mention the following:

• The lack of a height restriction causes the drop-down to, in some cases, span an almost comically large vertical space — i.e., from where-ever the form element is to the very top or bottom of the screen. Aside from being generally unsightly, this blocks out a lot of content on the page as well as any windows beneath the browser window, which can be a frustrating experience when you're trying to read something.

• It was mentioned that it might not be a common thing to have lots of saved log-ins for a single domain. Now that log-ins for sub-domains are included in the drop-down, i think it'll come up more often. It's especially problematic in the case of internal company networks, where you'll often have a million different Web applications under one domain (analytics.example.com, docker.example.com, git.example.com, mail.example.com, timekeeping.example.com, &c.). That was the scenario i ran into.

Comment 7

[Matthew N. [:MattN]]

Sorry, I should have directed you to bug 1561647 instead, though they may both get solved together. I'll reply there.