1329922 - [DTMF] Tones are not heard when duration is set to lowest (70)

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Cornel Ionce [:cornel_ionce], Desktop Release QA]

[Affected versions]:
- Nightly 53.0a1
- Aurora 52.0a2

[Affected platforms]:
- Windows 10 x64 / Windows 7 x64
- Mac OS X 10.11.5 / Mac OS X 10.12.1
- Ubuntu 12.04 x86 / Ubuntu 16.04 x64


[Steps to reproduce]:
1. Open Firefox and navigate to http://www.thegreatpotoo.com/webrtc-samples/src/content/peerconnection/dtmf/
2. Click on "call" and share your microphone
3. Set Duration to lowest (70).
4. Press/dial any number.

[Expected result]:
- The tone is heard each time a number is pressed.

[Actual result]:
- Tone is not heard.

[Regression range]:
This is not a regression.

Comment 1

[Dan Minor [:dminor]]

The actual cut off seems to be 100. 99 results in no sound, 100 works.

Comment 2

[Dan Minor [:dminor]]

Same bug exists in Google Chrome, problem is likely in webrtc.org code.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1329922 - Change kMinTelephoneEventDuration to match minimum duration in WebRTC spec;

The spec says 40 is the minimum, but here it is set to 100.

Review commit: https://reviewboard.mozilla.org/r/105138/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105138/

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8827468 [details]
Bug 1329922 - Change kMinTelephoneEventDuration to match minimum duration in WebRTC spec;

https://reviewboard.mozilla.org/r/105138/#review105970

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fb3b77822c1
Change kMinTelephoneEventDuration to match minimum duration in WebRTC spec; r=jesup

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0fb3b77822c1