Get rid of the crazy thinly template thingy from RegisterSets.h

NEW
Unassigned

Status

()

Core
JavaScript Engine: JIT
P5
normal
9 months ago
4 months ago

People

(Reporter: nbp, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 months ago
As commented multiple times in Bug 1321521, everybody agrees that the templates behind AllocatableSet and LiveSet are not easy to understand.

Bug 1143011 added these because many of the functions used on AllocatableSet were also used on LiveSet, even if technically this should not be the case as they serve 2 different purposes.

I do think that the AllocatableSetAccessors and the LiveSetAccessors are a nice abstractions for building such sets while reducing the opportunities for adding errors, however the SpecializedRegSet and CommonRegSet makes things harder to understand.

As part of this bug, we should move functions added by SpecializedRegSet and CommonRegSet to the AllocatableSet and the LiveSet classes, and remove unused functions.
(Reporter)

Updated

9 months ago
Flags: needinfo?(nicolas.b.pierron)
(Reporter)

Updated

4 months ago
Flags: needinfo?(nicolas.b.pierron)
You need to log in before you can comment on or make changes to this bug.