1330048 - Add localconfig option to disable features (ignoring the installed state of the modules)

Status: NEW

(Bugzilla :: Bugzilla-General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

This would *probably* entail...

Add: { name => 'feature_disable', default => sub { {} } } 
to https://github.com/bugzilla/bugzilla/blob/master/Bugzilla/Install/Localconfig.pm#L143

Add description as an entry named localconfig_disable_feature => << EOT,
...
EOT

to https://github.com/bugzilla/bugzilla/blob/master/template/en/default/setup/strings.txt.pl#L275

and finally:

    if (Bugzilla->localconfig->{disable_feature}{$feature_name}) {
        return $cache->{feature}{$feature_name} = 0;
    }
to https://github.com/bugzilla/bugzilla/blob/master/Bugzilla.pm#L274

Comment 1

[Heather Booker (:hboo)]

Hi! I'd like to work on this. 

In the strings.txt (https://github.com/bugzilla/bugzilla/blob/master/template/en/default/setup/strings.txt.pl#L275) file, everything seems to be in alphabetical order even within localconfig_x except for the last one, `localconfig_apache_size_limit`.

Do you still want localconfig_disable_feature added at the end of the `localconfig_x`s or do you want it in alphabetical order after localconfig_diffpath (here: https://github.com/bugzilla/bugzilla/blob/master/template/en/default/setup/strings.txt.pl#L190)?

Comment 2

[Heather Booker (:hboo)]

I'm not totally sure what the description of localconfig_disable_feature should be. Something like "You can disable features, ignoring the installed state of the modules." ?

Comment 3

[Dylan Hardison [:dylan] (he/him)]

(In reply to Heather Booker (:hboo) from comment #1)
> Hi! I'd like to work on this. 
> 
> In the strings.txt
> (https://github.com/bugzilla/bugzilla/blob/master/template/en/default/setup/
> strings.txt.pl#L275) file, everything seems to be in alphabetical order even
> within localconfig_x except for the last one,
> `localconfig_apache_size_limit`.

That was my fault. 

> Do you still want localconfig_disable_feature added at the end of the
> `localconfig_x`s or do you want it in alphabetical order after
> localconfig_diffpath (here:
> https://github.com/bugzilla/bugzilla/blob/master/template/en/default/setup/
> strings.txt.pl#L190)?

Alphabetical order is definitely preferred.

(In reply to Heather Booker (:hboo) from comment #2)
> I'm not totally sure what the description of localconfig_disable_feature
> should be. Something like "You can disable features, ignoring the installed
> state of the modules." ?

I think we can be a bit terse here -- although this makes me realize the documentation should really go into more detail about optional features...

I suggest:

Optional features are enabled as long as all their required modules are installed.
This variable can cause Bugzilla to ignore features, even if modules are detected.
For a list of feature names, consult Makefile.PL

Comment 4

[Heather Booker (:hboo)]

Awesome thanks! Pull request sent to Bugzilla on Github: https://github.com/bugzilla/bugzilla/pull/48/files

Comment 5

[Firefox Bug Husbandry Bot]

Removing good-first-bug keyword because team does not have bandwidth to mentor at the moment.