Closed Bug 1330060 Opened 4 years ago Closed 4 years ago

stylo: Gecko_GetServoDeclarationBlock does more work than it needs to

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(3 files)

There used to be reasons for it, but there aren't anymore.
Attachment #8825502 - Flags: review?(bkelly) → review+
Attachment #8825503 - Flags: review?(cam) → review+
Attachment #8825504 - Flags: review?(cam) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e9d6004ede7
part 1.  Move GetInlineStyleDeclaration up to Element so it doesn't have to be virtual.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/28444912fe3c
part 2.  Gecko_GetServoDeclarationBlock should use Element::GetInlineStyleDeclaration instead of reinventing it.  r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bbd694b4c18
part 3.  Update comment to correctly describe when we may have a Gecko style decl in Gecko_GetServoDeclarationBlock.  r=heycam
You need to log in before you can comment on or make changes to this bug.