1330060 - stylo: Gecko_GetServoDeclarationBlock does more work than it needs to

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

There used to be reasons for it, but there aren't anymore.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Move GetInlineStyleDeclaration up to Element so it doesn't have to be virtual

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Gecko_GetServoDeclarationBlock should use Element::GetInlineStyleDeclaration instead of reinventing it

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Update comment to correctly describe when we may have a Gecko style decl in Gecko_GetServoDeclarationBlock

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e9d6004ede7
part 1.  Move GetInlineStyleDeclaration up to Element so it doesn't have to be virtual.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/28444912fe3c
part 2.  Gecko_GetServoDeclarationBlock should use Element::GetInlineStyleDeclaration instead of reinventing it.  r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bbd694b4c18
part 3.  Update comment to correctly describe when we may have a Gecko style decl in Gecko_GetServoDeclarationBlock.  r=heycam

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e9d6004ede7
https://hg.mozilla.org/mozilla-central/rev/28444912fe3c
https://hg.mozilla.org/mozilla-central/rev/6bbd694b4c18