Closed Bug 1330076 Opened 3 years ago Closed 3 years ago
_chrome _ext _shutdown _cleanup .html into an xpcshell test
59 bytes, text/x-review-board-request
The goal of this issue is rewriting the toolkit/components/extensions/test/mochitest/test_chrome_ext_shutdown_cleanup.html into an xpcshell. One reason for doing so is related to Bug 1308271 which is going to ship a WebExtension as a system addon and it breaks this test because the GlobalManager is always initialized when this test runs. Converting this test into an xpcshell should prevent this failure because the new xpcshell test will not run in an environment with any preinstalled system addon (and as a nice side-effect, this test will run faster).
Attachment #8825565 - Flags: review?(aswan)
Pushed to try: - https://treeherder.mozilla.org/#/jobs?repo=try&revision=94a7521409d76ead6b98f6091a454cb4533930b9
Status: NEW → ASSIGNED
I can confirm that this test fixes the issues we have in bug 1308271. Thank you very much! :)
Comment on attachment 8825565 [details] Bug 1330076 - Rewrite test_chrome_ext_shutdown_cleanup.html into an xpcshell test https://reviewboard.mozilla.org/r/103690/#review104626
Attachment #8825565 - Flags: review?(aswan) → review+
Autoland couldn't rebase this for landing.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5) > Autoland couldn't rebase this for landing. My apologies for that. Patch rebased (with the small conflict resolved).
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/b04953cd621e Rewrite test_chrome_ext_shutdown_cleanup.html into an xpcshell test r=aswan
You need to log in before you can comment on or make changes to this bug.