1330076 - Rewrite test_chrome_ext_shutdown_cleanup.html into an xpcshell test

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The goal of this issue is rewriting the toolkit/components/extensions/test/mochitest/test_chrome_ext_shutdown_cleanup.html into an xpcshell.

One reason for doing so is related to Bug 1308271 which is going to ship a WebExtension as a system addon and it breaks this test because the GlobalManager is always initialized when this test runs.

Converting this test into an xpcshell should prevent this failure because the new xpcshell test will not run in an environment with any preinstalled system addon (and as a nice side-effect, this test will run faster).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1330076 - Rewrite test_chrome_ext_shutdown_cleanup.html into an xpcshell test

Review commit: https://reviewboard.mozilla.org/r/103690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103690/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Pushed to try:
- https://treeherder.mozilla.org/#/jobs?repo=try&revision=94a7521409d76ead6b98f6091a454cb4533930b9

Comment 3

[Dennis Schubert [:denschub]]

I can confirm that this test fixes the issues we have in bug 1308271. Thank you very much! :)

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8825565 [details]
Bug 1330076 - Rewrite test_chrome_ext_shutdown_cleanup.html into an xpcshell test

https://reviewboard.mozilla.org/r/103690/#review104626

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Autoland couldn't rebase this for landing.

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8825565 [details]
Bug 1330076 - Rewrite test_chrome_ext_shutdown_cleanup.html into an xpcshell test

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103690/diff/1-2/

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> Autoland couldn't rebase this for landing.

My apologies for that.

Patch rebased (with the small conflict resolved).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b04953cd621e
Rewrite test_chrome_ext_shutdown_cleanup.html into an xpcshell test r=aswan

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b04953cd621e