1330079 - Allow new tabs to be added to the session store during shutdown

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan Henning [:JanH]]

Followup from bug 1266594:

In order to reliably clear history etc. when requested, shutdown of the UI is now slightly (or not so slightly, if sanitizing takes longer than expected on a slow/busy/... device) delayed when compared to the start of Gecko shutdown. This means that there is a period where the UI will still handle new tabs (e.g. incoming intents from external apps) normally, however Gecko is already busy shutting down and will not save them in the session store with the current shutdown logic.

Comment 1

[Jan Henning [:JanH]]

So what had totally slipped off my radar was that obviously the Gecko browser window is closing more or less together with "application-quit" and the session store won't collect data from closed windows. I don't feel confident messing around with that, so there's nothing that easily can be done for that case.

However during testing it seems that with the right timing the session store can also receive the TabOpen event between quit-application-requested/-proceeding and application-quit. Ordinarily, we collect the window data one last time during quit-application-requested - when the data is flushed in response to application-quit, the window has already closed and no data is updated. As a partial fix, we could therefore have the session store collect the window data once more if a new tab is opened within that time span, i.e. while the load state is still STATE_QUITTING.

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1330079 - Collect window data one more time if a new tab arrives before application-quit.

This is relevant when a new tab is opened (e.g. through an intent from an external app) just as the user has pressed the Quit button (see bug 1266594), in which case the TabOpen event might reach the session store after Gecko shutdown has already started. If we're still in the preliminary phase and the browser window hasn't yet been closed, we can persist this new tab by collecting the session store data from the browser window once more.

Additionally, we now reset the time of the last backup when clearing the session store data, so the backup file is recreated as soon as possible after a history/tabs sanitisation, especially for users who are cleaning private data on exiting Firefox.

Review commit: https://reviewboard.mozilla.org/r/104970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104970/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8827274 [details]
Bug 1330079 - Collect window data one more time if a new tab arrives before application-quit.

https://reviewboard.mozilla.org/r/104970/#review105962

Comment 4

[Jan Henning [:JanH]]

tested locally, should be okay without a try run

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8754bb4f8c1
Collect window data one more time if a new tab arrives before application-quit. r=sebastian

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c8754bb4f8c1