1330226 - BidiParagraphData is rather alloc heavy

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: bidi_less_malloc.diff

Not sure if the patch goes too far.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=160c1ef6949cdfda1c14c25aff350ce346aaac79

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: bidi_less_malloc.diff

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8825674 [details] [diff] [review]
bidi_less_malloc.diff

This looks OK to me, but it's really more in jfkthame's wheelhouse -- punting to him.

(The one thing I'm less sure about here is whether 16 might be too large for the two newly-converted AutoTArrays here... I don't have a good feel for typical usage of this object, so I don't know how often we actually hit that many.  I wonder if 4 or 8 would be a better default size there [with failover to the heap in cases where that's exceeded of course].)

Anyway, I'll punt to jfkthame.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I noticed the allocations when profiling a google doc and there the number of items was most often 1-4, occasionally up to 16 then rarely over 20.
Happy to use lower number too.

Comment 4

[Jonathan Kew [:jfkthame]]

Comment on attachment 8825674 [details] [diff] [review]
bidi_less_malloc.diff

Review of attachment 8825674 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks. 16 seems a reasonable size for the auto-arrays, IMO; that should be enough that heap allocation here becomes pretty rare, though some complex content will still need it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0733a44cd6c5
BidiParagraphData should allocate less, r=jfkthame

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0733a44cd6c5