Closed Bug 1330492 Opened 3 years ago Closed 3 years ago

Assertion failure: mDocument->GetReadyStateEnum() == nsIDocument::READYSTATE_LOADING (Bad readyState)

Categories

(Core :: XSLT, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox-esr52 --- wontfix
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: truber, Assigned: RyanVM)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached file testcase.html
The attached testcase causes the assertion below in mozilla-central rev 63ad56438630

Assertion failure: mDocument->GetReadyStateEnum() == nsIDocument::READYSTATE_LOADING (Bad readyState), at /home/worker/workspace/build/src/dom/xslt/xslt/txMozillaTextOutput.cpp:86
Attached file log.txt
Maybe Peter has ideas about what's up here...
Flags: needinfo?(peterv)
Yeah, the assert should change, if mObserver is null then |mDocument->GetReadyStateEnum()| should be |nsIDocument::READYSTATE_INTERACTIVE| instead of |nsIDocument::READYSTATE_LOADING|.
Blocks: 1205163
Flags: needinfo?(peterv)
Priority: -- → P3
Flags: in-testsuite?
Attached patch patchSplinter Review
Per comment 3. I've confirmed that the crashtest fails without the patch and passes with it.
Assignee: nobody → ryanvm
Attachment #8911434 - Flags: review?(peterv)
Attachment #8911434 - Flags: review?(peterv) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26a6bdc37e04
Check for nsIDocument::READYSTATE_INTERACTIVE if mObserver is null. r=peterv
https://hg.mozilla.org/mozilla-central/rev/26a6bdc37e04
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Flags: in-testsuite? → in-testsuite+
Depends on: 1405416
You need to log in before you can comment on or make changes to this bug.