gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:442:21: error: reinterpret_cast from 'nullptr_t' to 'sfntly::ReadableFontData *' is not allowed

RESOLVED FIXED in Firefox 53

Status

()

Core
Printing: Output
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Jan Beich, Assigned: Jan Beich)

Tracking

({regression})

Trunk
mozilla53
Unspecified
FreeBSD
regression
Points:
---

Firefox Tracking Flags

(firefox50 unaffected, firefox51 unaffected, firefox52 unaffected, firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
NULL is defined via nullptr in C++11 mode on FreeBSD.
https://github.com/freebsd/freebsd/commit/c8ed04c26b67

In file included from objdir/gfx/sfntly/cpp/src/Unified_cpp_gfx_sfntly_cpp_src2.cpp:20:
gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:442:21: error: reinterpret_cast from
      'nullptr_t' to 'sfntly::ReadableFontData *' is not allowed
    : CMap::Builder(reinterpret_cast<ReadableFontData*>(NULL),
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:566:34: error: reinterpret_cast from
      'nullptr_t' to 'sfntly::WritableFontData *' is not allowed
                               : reinterpret_cast<WritableFontData*>(NULL),
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:577:34: error: reinterpret_cast from
      'nullptr_t' to 'sfntly::ReadableFontData *' is not allowed
                               : reinterpret_cast<ReadableFontData*>(NULL),
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:961:21: error: reinterpret_cast from
      'nullptr_t' to 'sfntly::ReadableFontData *' is not allowed
    : CMap::Builder(reinterpret_cast<ReadableFontData*>(NULL),
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:969:21: error: reinterpret_cast from
      'nullptr_t' to 'sfntly::ReadableFontData *' is not allowed
    : CMap::Builder(reinterpret_cast<ReadableFontData*>(NULL),
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 errors generated.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 years ago
Apologies for not upstreaming this. Google's has a stupid policy of forcing volunteers to submit to its panopticon via CLA -> Google Account -> Tor signup is not allowed. I'm contributing my time, not privacy. Ironically, even Facebook allows signing CLA over GitHub.

Can you help?
Have you at least _reported_ this upstream (or could you please do so), even if you don't submit a patch there? Thanks.
Comment hidden (mozreview-request)
(Assignee)

Comment 5

2 years ago
(In reply to Jonathan Kew (:jfkthame) from comment #3)
> Have you at least _reported_ this upstream...?

Thanks for reminding. Done, including their broken unit tests.
Does the solution I just suggested in https://github.com/googlei18n/sfntly/issues/67 work for you? If so, I'd prefer to go that way.
Comment hidden (mozreview-request)
(Assignee)

Comment 8

2 years ago
(In reply to Jonathan Kew (:jfkthame) from comment #6)
> Does the solution I just suggested in
> https://github.com/googlei18n/sfntly/issues/67 work for you? If so, I'd
> prefer to go that way.

Yep. My Firefox build just finished using comment 7 version.

Comment 9

2 years ago
mozreview-review
Comment on attachment 8826045 [details]
Bug 1330495 - Unbreak FreeBSD build after bug 1324739.

https://reviewboard.mozilla.org/r/104094/#review104906

I'm OK with doing this locally for now to unbreak your build, but let's try to keep an eye on upstream and (if necessary) prompt them to fix it there as well, otherwise it'll probably come back to bite us again in a future update.
Attachment #8826045 - Flags: review?(jfkthame) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
Assignee: nobody → jbeich

Comment 10

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0f21e0ef8d83
Unbreak FreeBSD build after bug 1324739. r=jfkthame
Keywords: checkin-needed

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0f21e0ef8d83
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.