1330495 - gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:442:21: error: reinterpret_cast from 'nullptr_t' to 'sfntly::ReadableFontData *' is not allowed

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Jan Beich]

NULL is defined via nullptr in C++11 mode on FreeBSD.
https://github.com/freebsd/freebsd/commit/c8ed04c26b67

In file included from objdir/gfx/sfntly/cpp/src/Unified_cpp_gfx_sfntly_cpp_src2.cpp:20:
gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:442:21: error: reinterpret_cast from
      'nullptr_t' to 'sfntly::ReadableFontData *' is not allowed
    : CMap::Builder(reinterpret_cast<ReadableFontData*>(NULL),
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:566:34: error: reinterpret_cast from
      'nullptr_t' to 'sfntly::WritableFontData *' is not allowed
                               : reinterpret_cast<WritableFontData*>(NULL),
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:577:34: error: reinterpret_cast from
      'nullptr_t' to 'sfntly::ReadableFontData *' is not allowed
                               : reinterpret_cast<ReadableFontData*>(NULL),
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:961:21: error: reinterpret_cast from
      'nullptr_t' to 'sfntly::ReadableFontData *' is not allowed
    : CMap::Builder(reinterpret_cast<ReadableFontData*>(NULL),
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gfx/sfntly/cpp/src/sfntly/table/core/cmap_table.cc:969:21: error: reinterpret_cast from
      'nullptr_t' to 'sfntly::ReadableFontData *' is not allowed
    : CMap::Builder(reinterpret_cast<ReadableFontData*>(NULL),
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 errors generated.

Comment 1

[Jan Beich]

Attachment: Bug 1330495 - Unbreak FreeBSD build after bug 1324739.

Review commit: https://reviewboard.mozilla.org/r/104094/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104094/

Comment 2

[Jan Beich]

Apologies for not upstreaming this. Google's has a stupid policy of forcing volunteers to submit to its panopticon via CLA -> Google Account -> Tor signup is not allowed. I'm contributing my time, not privacy. Ironically, even Facebook allows signing CLA over GitHub.

Can you help?

Comment 3

[Jonathan Kew [:jfkthame]]

Have you at least _reported_ this upstream (or could you please do so), even if you don't submit a patch there? Thanks.

Comment 4

[Jan Beich]

Comment on attachment 8826045 [details]
Bug 1330495 - Unbreak FreeBSD build after bug 1324739.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104094/diff/1-2/

Comment 5

[Jan Beich]

(In reply to Jonathan Kew (:jfkthame) from comment #3)
> Have you at least _reported_ this upstream...?

Thanks for reminding. Done, including their broken unit tests.

Comment 6

[Jonathan Kew [:jfkthame]]

Does the solution I just suggested in https://github.com/googlei18n/sfntly/issues/67 work for you? If so, I'd prefer to go that way.

Comment 7

[Jan Beich]

Comment on attachment 8826045 [details]
Bug 1330495 - Unbreak FreeBSD build after bug 1324739.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104094/diff/2-3/

Comment 8

[Jan Beich]

(In reply to Jonathan Kew (:jfkthame) from comment #6)
> Does the solution I just suggested in
> https://github.com/googlei18n/sfntly/issues/67 work for you? If so, I'd
> prefer to go that way.

Yep. My Firefox build just finished using comment 7 version.

Comment 9

[Jonathan Kew [:jfkthame]]

Comment on attachment 8826045 [details]
Bug 1330495 - Unbreak FreeBSD build after bug 1324739.

https://reviewboard.mozilla.org/r/104094/#review104906

I'm OK with doing this locally for now to unbreak your build, but let's try to keep an eye on upstream and (if necessary) prompt them to fix it there as well, otherwise it'll probably come back to bite us again in a future update.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f21e0ef8d83
Unbreak FreeBSD build after bug 1324739. r=jfkthame

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0f21e0ef8d83