Closed
Bug 1330532
Opened 8 years ago
Closed 8 years ago
Allow enabling JIT optimization tracking separately from profiling
Categories
(Core :: JavaScript Engine: JIT, defect, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: sfink, Assigned: h4writer)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.30 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
Right now, enabling profiling also enables JIT optimization tracking. At least in one profile, we had 500ms in findAllocationSite out of a <10s run (I don't remember which one this was, sorry.) So when not using the opt tracking info, I would like to turn it off while profiling.
Assignee | ||
Updated•8 years ago
|
Priority: -- → P1
Assignee | ||
Comment 2•8 years ago
|
||
This disable tracking optimization by default. It is currently not used and it is bad that it is skewing the results of the SPS profiler. When using IONFLAGS=trackopts it is enabled by default again.
Just setting JitOptions.disableOptimizationTracking to false (in c++) should enable it. I.e. that is our place to flip things. It can be easily patched to have an about:config entry.
Also setting the environment variable JIT_OPTION_disableOptimizationTracking=false will enable the optimization tracking again. (in all sort of builds).
Assignee: nobody → hv1989
Attachment #8834500 -
Flags: review?(shu)
Comment 3•8 years ago
|
||
Comment on attachment 8834500 [details] [diff] [review]
Disable tracking optimizations by default
Review of attachment 8834500 [details] [diff] [review]:
-----------------------------------------------------------------
Let me pour one out.
Attachment #8834500 -
Flags: review?(shu) → review+
Pushed by hv1989@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40d1d2440c9a
Don't enable optimization tracking by default, r=shu
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•