1330574 - Correct WebRenderContainerLayer overflow rect

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Ethan Lin[:ethlin]]

The overflow rect in WRContainerLayer is wrong. It should be same as other WRXXXLayer. I'll fix it.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Part1. Correct overflow rect

The overflow rect's top left point should be zero. It's different from 'relBounds'.

Comment 2

[Ethan Lin[:ethlin]]

Attachment: Part2. mark some reftests as passing

Based on the try server result[1] with Part1 patch, I mark some reftests as passing.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d86e73a3a9fe7b1ca1025817f180275452d9c4c5

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8826117 [details] [diff] [review]
Part1. Correct overflow rect

Review of attachment 8826117 [details] [diff] [review]:
-----------------------------------------------------------------

Update the printf as well. I don't know if anybody is still using that but might as well keep it up to date.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8826118 [details] [diff] [review]
Part2. mark some reftests as passing

Review of attachment 8826118 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, this fixes a lot!

Comment 5

[Ethan Lin[:ethlin]]

try looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dcf2da57a231e1681376b4d715112710c188e8af

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/873c64225267
Part1. Correct WebRenderContainerLayer overflow rect. r=kats
https://hg.mozilla.org/projects/graphics/rev/248399829d40
Part2. Mask some reftests as passing after fix WebRenderContainerLayer overflow rect. r=kats

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/90ff62d4c2b9
Remove unnecessary change of testcase. r=gfx?