1330611 - [compact layout] icons look vertically misaligned in alternative default tiles

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Dão Gottwald [:dao]]

Attachment: Screenshot

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1330611 - [compact layout] position thumbnails more towards the top in default tiles.

Review commit: https://reviewboard.mozilla.org/r/104168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104168/

Comment 2

[Dão Gottwald [:dao]]

Attachment: Screenshot with patch

Note that my patch conflates browser.newtabpage.compact with browser.newtabpage.directory.source, which is technically incorrect but should be fine since we have browser.newtabpage.compact and  browser.newtabpage.directory.source's alternative value only for the funnelcake and will eventually get rid of these distinctions.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8826154 [details]
Bug 1330611 - [compact layout] position thumbnails more towards the top in default tiles.

https://reviewboard.mozilla.org/r/104168/#review104898

::: browser/themes/shared/newtab/newTab.inc.css:192
(Diff revision 1)
>  .newtab-site[type=sponsored] .newtab-thumbnail {
>    background-position: center center;
>  }
>  
> +body.compact .newtab-site[type=affiliate] .newtab-thumbnail {
> +  background-position: center 30%;

The screenshots look good, so r=me, but we should probably do something in a followup that will still be correct if we change the title size.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07bb50e7122d
[compact layout] position thumbnails more towards the top in default tiles. r=Gijs

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8826154 [details]
Bug 1330611 - [compact layout] position thumbnails more towards the top in default tiles.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1322731 & bug 1322738
[User impact if declined]: see attachment 8826152 [details]
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: probably no dedicated test needed
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: small and isolated fix, will only affect the funnelcake build
[String changes made/needed]: /

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8826154 [details]
Bug 1330611 - [compact layout] position thumbnails more towards the top in default tiles.

Layout fix for the onboarding funnelcake experiment.

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/41f18ace160f8aa99ecb68a243d836ece87342b9

https://hg.mozilla.org/releases/mozilla-beta/rev/39644d68fc6dfae3c22b948d8edacdd1a0bd7b9f

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/07bb50e7122d

Comment 9

[Surentharan]

[bugday-20170125]