1330649 - SETA - Rename `RunnableJobsClient`

Status: RESOLVED WONTFIX

(Tree Management Graveyard :: Treeherder: SETA, defect, P3)

Description

[Armen [:armenzg]]

I'm currently moving a couple of functions as part of another PR but I would like to port the left over logic in this bug.

Specifically the caching logic is the only left:
https://github.com/mozilla/treeherder/blob/master/treeherder/seta/runnable_jobs.py#L15-L38

This will require stop using RunnableJobsClient in all the various places:
https://github.com/mozilla/treeherder/search?utf8=%E2%9C%93&q=RunnableJobsClient

Comment 1

[Robert Wood [:rwood]]

I'm not sure if this is really necessary. I think it makes sense to have SETA use it's own RunnableJobsClient (wrapper for treeherder/etl/runnable_jobs) and keep it's own caching there just for SETA, instead of changing the treeherder runnable_jobs endpoint and potentially inadvertently causing issues for some other treeherder runnable jobs API consumer.

:emorley, what do you think? If you agree, I'm going to close this bug.

Comment 2

[Ed Morley [:emorley]]

To me `RunnableJobsClient` is a bit confusing, since elsewhere in Treeherder we used "Client" to refer to things like the standalone Python Treeherder client that makes HTTP calls to an API, rather than a helper for interacting with the ORM.

Comment 3

[Robert Wood [:rwood]]

Good point, thanks - I'll (at least) improve the name.

Comment 4

[Ed Morley [:emorley]]

RunnableJobsClient is being removed here (in favour of calling list_runnable_jobs() directly):
https://github.com/mozilla/treeherder/pull/4590