Make bug modal page work with skins other than Mozilla

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
User Interface: Modal
P2
minor
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dvander, Assigned: dkl)

Tracking

Production

Details

Attachments

(4 attachments)

Created attachment 8826328 [details]
Capture2.PNG

When I enable the experimental UI (which is nice, BTW), I can't use the classic theme anymore. I much prefer the Classic theme to the Mozilla one. Comments are hard to read/follow when everything is light and washed out. There's not enough contrast (screenshot attached).
Created attachment 8826350 [details]
modal.png

weird - the text is black / high contrast for everyone else (see attached screenshot).
Could you save the page (using "webpage complete" File -> Save As, and choosing "web page, complete" ) and upload that? I'd like to look at the markup and CSS.
Flags: needinfo?(dvander)
Sorry for the late reply. That screenshot was Chrome on Windows 10, though Firefox on Windows doesn't look much better. Let me get that save for you.
Flags: needinfo?(dvander)
Created attachment 8827790 [details]
bug1330774.zip

Complete save of viewing this bug in Firefox 51, on Windows 10, with the experimental UI.
(Assignee)

Comment 5

a year ago
I tried using the bug modal page with both Dusk and Classic and it is entirely usable in its current state. Only things I could notice right away is the look of the major and minor buttons are drastically different (Firefox nightly, OSX). Otherwise things work and look fine. IMO, we can fix the buttons and then remove the restriction for the Mozilla skin when the bug modal form is enabled.

Question for now is, should this be a blocker for making the modal form the default? Otherwise when we turn it on, alot of people are going to be forced to use the Mozilla skin that have been using others this whole time.

dkl
Flags: needinfo?(mcote)
Flags: needinfo?(dylan)
Summary: New bug page w/ Classic UI → Make bug modal page work with skins other than Mozilla
My opinion is that it should not be a blocker, it can however be done right after the other work.

Adjusting priority to indicate that.
Severity: normal → minor
Flags: needinfo?(dylan)
Priority: -- → P2
I agree.  We need to communicate this just before switch it to the default as well.  I also think the work we put into other themes should be *very* minimal.
Flags: needinfo?(mcote)
(Assignee)

Comment 8

a year ago
Created attachment 8827945 [details] [diff] [review]
1330774_1.patch

I have just remove the enforcement of the Mozilla skin. I will file a separate bug that addresses the button inconsistency that can be fixed after we make modal default.

dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attachment #8827945 - Flags: review?(dylan)
(Assignee)

Updated

a year ago
Blocks: 1150541
This is something we can release note when Modal becomes the default.
Comment on attachment 8827945 [details] [diff] [review]
1330774_1.patch

As discussed last week, we need to still force people to use the new skin, but allow disabling it (with a note that patches to fix it are welcomed)
Attachment #8827945 - Flags: review?(dylan)
(Assignee)

Comment 11

a year ago
(In reply to Dylan Hardison [:dylan] from comment #10)
> Comment on attachment 8827945 [details] [diff] [review]
> 1330774_1.patch
> 
> As discussed last week, we need to still force people to use the new skin,
> but allow disabling it (with a note that patches to fix it are welcomed)

I have applied the current version of this patch to bugzilla-dev.allizom.org so that testers can see what the modal UI looks like with other skins. And to show that the modal UI is very usable in it's current state.

dkl
Looks a bit weird, but nothing egregious leaps out.  As you say, very usable.
(Assignee)

Updated

a year ago
Attachment #8827945 - Flags: review?(dylan)
Comment on attachment 8827945 [details] [diff] [review]
1330774_1.patch

Review of attachment 8827945 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8827945 - Flags: review?(dylan) → review+
(Assignee)

Comment 14

a year ago
To https://github.com/mozilla-bteam/bmo.git
   e81dc87..c4dd847  master -> master
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.