1330858 - hide the `Object` keyword when showing cookies object

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[[e-mail]]

from bug 1317649,

when there are other cookies properties besides 'name', 'value', the request and response cookies shows as Object Rep (show `Object` keyword instead of cookie value, and show all properties in sub list)

We should display cookie value instead of `Object` keyword. It can be done by customize the rendering using `renderValue` per (callback) in properties-view(TreeView) component

Comment 1

[Marco Mucci [:MarcoM]]

Hi Fred, should this bug be set to 'qe-verify+' or 'qe-verify-'

Comment 2

[[e-mail]]

It will change UI so its qe-verify+

Comment 3

[[e-mail]]

Attachment: Bug 1330858 - Hide Object string for cookies object;

Review commit: https://reviewboard.mozilla.org/r/105038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105038/

Comment 4

[[e-mail]]

Comment on attachment 8827316 [details]
Bug 1330858 - Hide Object string for cookies object;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105038/diff/1-2/

Comment 5

[[e-mail]]

Comment on attachment 8827316 [details]
Bug 1330858 - Hide Object string for cookies object;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105038/diff/2-3/

Comment 6

[[e-mail]]

Comment on attachment 8827316 [details]
Bug 1330858 - Hide Object string for cookies object;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105038/diff/3-4/

Comment 7

[[e-mail]]

As discussed in daily meeting, the PR hide the `Object` string for cookies object Rep, and not trying to mimic the original UI. (For the record the origin cookies object tree usage is buggy. When user tap the value after object, the value is selectable but the toggle sign and sub tree are disappeared.) Now we keep the consistent treeview usage without disturbing info (`Object` string is meaningless for cookies).

I put the logic in `properties-view` to not duplicate the `renderValueWithRep` method in CookiesPanel. Since for all sidebar panels we pretty sure the case (member.value is an object and there is a `member.value.value` property) is only happened in Cookies panel

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8827316 [details]
Bug 1330858 - Hide Object string for cookies object;

https://reviewboard.mozilla.org/r/105038/#review105918

Works for me, thanks Fred.

R+ assuming try is green.

Honza

Comment 9

[[e-mail]]

try green (with unrelated webconsole intermittent), thanks

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9380dbe4177
Hide Object string for cookies object;r=Honza

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d9380dbe4177

Comment 12

[Ciprian Georgiu, Desktop QA]

I've managed to reproduce this issue on a Nightly build from (2017-01-12).
This is verified fixed on latest Aurora 53.0a2 (2017-01-25) on the following OSes:
- Windows 10 x64
- Mac OS 10.11.6
- Ubuntu 16.04 x64 LTS