Closed
Bug 1330921
Opened 7 years ago
Closed 7 years ago
Fix the coordinate of WebRenderColorLayer
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: ethlin, Assigned: ethlin)
References
Details
Attachments
(2 files)
|
2.09 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
|
4.91 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
For now we don't handle the coordinate of WebRenderColorLayer correctly. It should also do push/pop stacking context.
|
Assignee | |
Comment 1•7 years ago
|
||
We should do push/pop stackcontext in WRColorLayer, like other WR Layers.
Attachment #8826554 -
Flags: review?(bugmail)
|
|
Assignee | |
Comment 2•7 years ago
|
||
For the try result [1], there are 3 unexpected-fail tests. We rendered colorlayer in the wrong position previously and coincidentally make these tests passed. So I mark fails-if now. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f6bb2f343aa03d611f79f6ba3f9e1c703dc0483&selectedJob=68777790
Attachment #8826555 -
Flags: review?(bugmail)
|
||
Updated•7 years ago
|
Attachment #8826554 -
Flags: review?(bugmail) → review+
|
|
||
Updated•7 years ago
|
Attachment #8826555 -
Flags: review?(bugmail) → review+
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/f209e29af7ef Backout 6699d31aaa45 because I forgot the bug number
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/63f32c8cc11b Actually backout 6699d31aaa45 because I forgot the bug number
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/3b8ff954dfba Fix the coordinates of WebRenderColorLayer. r=kats
|
||
Comment 6•7 years ago
|
||
Ethan did you have more work that you planed to do in this bug?
Status: RESOLVED → REOPENED
Flags: needinfo?(ethlin)
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•7 years ago
|
||
Nope, thanks for the push.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Flags: needinfo?(ethlin)
Resolution: --- → FIXED
|
|
||
Updated•7 years ago
|
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•