Fix the coordinate of WebRenderColorLayer

RESOLVED FIXED in mozilla54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ethlin, Assigned: ethlin)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
For now we don't handle the coordinate of WebRenderColorLayer correctly. It should also do push/pop stacking context.
(Assignee)

Comment 1

2 years ago
Created attachment 8826554 [details] [diff] [review]
Part1. Fix the position of WRColorLayer

We should do push/pop stackcontext in WRColorLayer, like other WR Layers.
Attachment #8826554 - Flags: review?(bugmail)
(Assignee)

Comment 2

2 years ago
Created attachment 8826555 [details] [diff] [review]
Part2. mark fails-if for some tests

For the try result [1], there are 3 unexpected-fail tests. We rendered colorlayer in the wrong position previously and coincidentally make these tests passed. So I mark fails-if now.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f6bb2f343aa03d611f79f6ba3f9e1c703dc0483&selectedJob=68777790
Attachment #8826555 - Flags: review?(bugmail)
Attachment #8826554 - Flags: review?(bugmail) → review+
Attachment #8826555 - Flags: review?(bugmail) → review+

Comment 3

2 years ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/f209e29af7ef
Backout 6699d31aaa45 because I forgot the bug number
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 4

2 years ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/63f32c8cc11b
Actually backout 6699d31aaa45 because I forgot the bug number

Comment 5

2 years ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/3b8ff954dfba
Fix the coordinates of WebRenderColorLayer. r=kats
Ethan did you have more work that you planed to do in this bug?
Status: RESOLVED → REOPENED
Flags: needinfo?(ethlin)
Resolution: FIXED → ---
(Assignee)

Comment 7

2 years ago
Nope, thanks for the push.
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Flags: needinfo?(ethlin)
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.