1331005 - get_pings_properties doesn't work for filtering GPU process histograms

Status: RESOLVED FIXED

(Data Platform and Tools :: General, defect, P1)

Description

[George Wright (:gw280) (needinfo me!)]

e.g. GPU_PROCESS_INTIIALIZATION_TIME_MS. I think GPU stuff needs to be handled here: https://github.com/mozilla/python_moztelemetry/blob/master/moztelemetry/spark.py#L251, like:

children += [_get_ping_property(child, path, histograms_url,
                                        additional_histograms) \
for child in cursor.get("gpu", {})]

Comment 1

[George Wright (:gw280) (needinfo me!)]

For now it works if you do:

histograms = get_pings_properties(pings, "payload/processes/gpu/histograms/GPU_PROCESS_INITIALIZATION_TIME_MS")

Comment 2

[George Wright (:gw280) (needinfo me!)]

Attachment: 0001-Support-GPU-process-histograms-keyedHistograms-in-ge.patch

This patch should work. The only thing I'd want to question is whether we'd want to aggregate the content and gpu histograms under HISTOGRAM_children or have separate HISTOGRAM_content and HISTOGRAM_gpu containers.

Comment 3

[GitHub Autolander Bot]

Attachment: [python_moztelemetry] gw280:master > mozilla:master

Comment 4

[Mark Reid [:mreid]]

Mauro, it looks like the PR here has been merged, can we close this bug?

Comment 5

[Mark Reid [:mreid]]

Please reopen if this bug needs more work.