1331059 - android_events should record full session information

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Metrics: Pipeline, defect, P2)

Comment 1

[Frank Bertsch [:frank]]

A few questions:

1. If sessions begins with "experiments", do we want to store that as an experiment or as a session?
2. Do we want to pre-process sessions, into (session, version, suffix)?

Comment 2

[:Grisha Kruglov]

Didn't mean to reset needinfo; I'll update soon. Thanks for filing this, Frank.

Comment 3

[:Grisha Kruglov]

(In reply to Frank Bertsch [:frank] from comment #1)
> A few questions:
> 
> 1. If sessions begins with "experiments", do we want to store that as an
> experiment or as a session?

Let's keep them as experiments and not change the current processing here.

We have queries depending on this pattern, and overall it seems useful to keep experiments separate from sessions, even though they both define a "scope" of an event and _could_ be the same thing.

Another option is to do both - keep the session name intact here, but also parse out the experiment name. Other than consistency, this wins us nothing, though. The current way might not be 100% consistent with how sessions should behave, however, we've already "hijacked" this particular special session at some point in the past, and this approach works well enough. I'll file a bug to document the current behaviour on the client side.

> 2. Do we want to pre-process sessions, into (session, version, suffix)?

While this doesn't seem strictly necessary for now, I think it would help speed up queries if we find ourselves often querying for these subcomponents separately. Since session processing is the way it is currently, none of the existing queries will benefit from this at the moment, but that might change going forward. Let's keep an eye out for this as a low hanging perf improvement?

Comment 5

[:Grisha Kruglov]

Frank, do you have a rough timeline for when this might get fixed? It'll be good to construct our A-S dashboard queries with correct filters :-)

Comment 6

[Frank Bertsch [:frank]]

(In reply to :Grisha Kruglov from comment #5)
> Frank, do you have a rough timeline for when this might get fixed? It'll be
> good to construct our A-S dashboard queries with correct filters :-)

Grisha, I can put this on the front of the priority queue if it's blocking efforts on your end.

Comment 7

[Frank Bertsch [:frank]]

I can work on this Monday 1/23 if so.

Comment 8

[:Grisha Kruglov]

(In reply to Frank Bertsch [:frank] from comment #7)
> I can work on this Monday 1/23 if so.

That's great, thank you Frank!

Comment 9

[Frank Bertsch [:frank]]

Okay, this has been merged. I'm going to keep this open until the first successful run - next run will begin on 2017-01-27 at 00:00 UTC.

Comment 10

[Frank Bertsch [:frank]]

Looks like this worked as expected. See [0] for an example that shows some of the new sessions. Closing as complete.

[0] https://sql.telemetry.mozilla.org/queries/2423/source