1331173 - Bigger Header segment capacity for TaskTracer

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Thinker Li [:sinker]]

When TaskTracer is enabled at run-time, the size of |IPC::Message::Header| would grow.  For MacOSX, its size is bigger than the default header segment capacity.  So, |kHeaderSegmentCapacity| should be increased for TaskTracer.

Comment 1

[Thinker Li [:sinker]]

Attachment: Increase header segment capacity for TaskTracer

Bill, without this change, deserializing would be broken for MacOSX when TaskTracer is enabled.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8826837 [details] [diff] [review]
Increase header segment capacity for TaskTracer

Review of attachment 8826837 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/chromium/src/base/pickle.cc
@@ +28,3 @@
>  static const uint32_t kHeaderSegmentCapacity = 64;
> +#else
> +static const uint32_t kHeaderSegmentCapacity = 128;

Please comment than TaskTracer uses some extra fields in the header.

Comment 3

[Thinker Li [:sinker]]

Attachment: Increase header segment capacity for TaskTracer, v2

Comment 4

[Thinker Li [:sinker]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b0502bc7961aaa413f27fb51e1d781eeca0b5ad

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68e6acf47dab
Increase header segment capacity for TaskTracer. r=billm

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/68e6acf47dab