Bigger Header segment capacity for TaskTracer

RESOLVED FIXED in Firefox 55

Status

()

Core
IPC
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: sinker, Assigned: sinker)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
When TaskTracer is enabled at run-time, the size of |IPC::Message::Header| would grow.  For MacOSX, its size is bigger than the default header segment capacity.  So, |kHeaderSegmentCapacity| should be increased for TaskTracer.
(Assignee)

Comment 1

2 years ago
Created attachment 8826837 [details] [diff] [review]
Increase header segment capacity for TaskTracer

Bill, without this change, deserializing would be broken for MacOSX when TaskTracer is enabled.
Attachment #8826837 - Flags: review?(wmccloskey)
Comment on attachment 8826837 [details] [diff] [review]
Increase header segment capacity for TaskTracer

Review of attachment 8826837 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/chromium/src/base/pickle.cc
@@ +28,3 @@
>  static const uint32_t kHeaderSegmentCapacity = 64;
> +#else
> +static const uint32_t kHeaderSegmentCapacity = 128;

Please comment than TaskTracer uses some extra fields in the header.
Attachment #8826837 - Flags: review?(wmccloskey) → review+
Assignee: nobody → tlee
Blocks: 1323076
(Assignee)

Updated

a year ago
Keywords: checkin-needed
(Assignee)

Comment 3

a year ago
Created attachment 8845842 [details] [diff] [review]
Increase header segment capacity for TaskTracer, v2
Attachment #8826837 - Attachment is obsolete: true
Attachment #8845842 - Flags: review+

Comment 5

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68e6acf47dab
Increase header segment capacity for TaskTracer. r=billm
Keywords: checkin-needed

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/68e6acf47dab
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
status-firefox53: affected → ---
You need to log in before you can comment on or make changes to this bug.