1331218 - Invalid value in devtools.toolbox.toolbarSpec breaks Toolbox buttons

Status: VERIFIED FIXED

(DevTools :: Framework, defect, P2)

Description

[Sebastian Zartner [:sebo]]

An invalid value for the devtools.toolbox.toolbarSpec preference breaks the Toolbox buttons including the Inspector button.

In my case the preference within prefs.js looked like this:

user_pref("devtools.toolbox.toolbarSpec", "[\"firebug open\", \"paintflashing toggle\", \"tilt toggle\", \"scratchpad\", \"resize toggle\"]");

The following related exception is shown within the Browser Toolbox:

Error: No command 'firebug open'
Stack trace:
createCommandButtons/</<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/developer-toolbar.js:92:17
...

(Regarding the exception's stack trace, it looks like this bug is related to the GCLI code, though as it breaks the Toolbox buttons I put it in the "Framework" component.)

Sebastian

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Do you how you arrived at the invalid value?  Is this something the Firebug add-on would add?

Comment 2

[Sebastian Zartner [:sebo]]

Firebug at least adds some GCLI commands[1], but it doesn't add that entry by default and unfortunately I can't tell you how I arrived at the invalid value. I can just tell you that I did not edit the value manually.

Independent of that question, this also happens for other invalid values like "[\"foo\"]".

Maybe the dependency on that preference should be removed completely, as the sense behind it seems to be questionable.

Sebastian

[1] https://github.com/firebug/firebug/blob/313e5bece064c0fb0ab7db123a38ba3b90dfc922/extension/modules/gcli.js#L146-L182

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

At the very least, it would seem we should just ignore an invalid item in the array, to avoid breaking the toolbox.

:ochameau, it seem you are changing some related things in bug 1320149.  Is the toolbarSpec pref still used after your changes?

Comment 4

[Alexandre Poirot [:ochameau]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> :ochameau, it seem you are changing some related things in bug 1320149.  Is
> the toolbarSpec pref still used after your changes?

No. It looks like I can also cleanup this toolbarSpec related code.
So if I move forward with bug 1320149 as-is, this bug won't exist anymore.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Bug 1320149 removed toolbarSpec, so this issue seems fixed.

Comment 6

[Sebastian Zartner [:sebo]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> Bug 1320149 removed toolbarSpec, so this issue seems fixed.

Yes, I can confirm that. Thank you for closing that bug!

Sebastian