1331236 - Make nsPrintingPromptServiceX.mm cpp file instead of object c file

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect)

Description

[Makoto Kato [:m_kato] (PTO until 5/6)]

Final goal is sharing code for toolkit/components/printui/ for dialog.

We don't use objective-c code into nsPrintingPromptServiceX.mm, but this extension is mm.

Comment 1

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: Bug 1331236 - Make nsPrintingPromptServiceX.mm cpp file instead of Objective-C++.

nsPrintingPromptServiceX doesn't use Objective-C, so we should change to C++ instead.

Also, nsPrintDialogServiceX::ShowPageSetup should have NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT.

Review commit: https://reviewboard.mozilla.org/r/104878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104878/

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8827039 [details]
Bug 1331236 - Make nsPrintingPromptServiceX.mm cpp file instead of Objective-C++.

https://reviewboard.mozilla.org/r/104878/#review105550

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/224be03d946c
Make nsPrintingPromptServiceX.mm cpp file instead of Objective-C++. r=mstange

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/224be03d946c