1331308 - remove 2 add-ons from allow list

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[:shell escalante]

[Tracking Requested - why for this release]:  remove 2 more add-ons from system add-on targeting "allow list" that were identified by users as not working for Beta and before Release 51.  they didn't break in Beta (tested performance and stability) - but with e10s the functionality doesn't work.

1Password	[e-mail]	4.6.2
Self-Destructing Cookies	   jid0-9XfBwUWnvPx4wWsfBWMCm4Jj69E@jetpack	0.4.11

After Release goes out - we will block with the system add-on as needed - but this is a very low risk change and avoids the issue entirely.   Blocking is not 100% (need to get the system add-on update) - so removing issue is better.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1331308 - Remove two addons from e10s allow list as they don't work.

Review commit: https://reviewboard.mozilla.org/r/104988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104988/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8827262 [details]
Bug 1331308 - Remove two addons from e10s allow list as they don't work.

This is a very simple removal of two add-ons from the list that was added in bug 1329015. If there's another RC I suggest we take this patch to avoid having to do a system add-on update.

Note: It's my understanding that these add-ons don't cause problems, their functionaly just doesn't work.. so the best would be to leave users of these add-ons on non-e10s (which is what this change is about).

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8827262 [details]
Bug 1331308 - Remove two addons from e10s allow list as they don't work.

https://reviewboard.mozilla.org/r/104988/#review105762

Don't forget to bump the version!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8827262 [details]
Bug 1331308 - Remove two addons from e10s allow list as they don't work.

https://reviewboard.mozilla.org/r/104988/#review105762

Sorry, didn't mean to use the imperitive there without an emoticon. Let me try again:

Don't forget to bump the version! :)

Comment 5

[:Felipe Gomes (needinfo for replies!)]

This hasn't gone out yet to release so we can skip bumping the version. If this doesn't make the RC and we need to update through GoFaster I'll do it.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8827262 [details]
Bug 1331308 - Remove two addons from e10s allow list as they don't work.

Taking a couple of addons off the e10s whitelist for 51. 
This should be included if we do an RC2 later this week.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Landed on mozilla-release:
https://hg.mozilla.org/releases/mozilla-release/rev/9f938c1a1473bdaafe761245710071adf10ae881

I don't know if I should change status-firefox51 to fixed now or wait to see if there'll be another RC.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8827262 [details]
Bug 1331308 - Remove two addons from e10s allow list as they don't work.

Approval Request Comment
Since this made to mozilla-release, we should also land it on the other trees so that the code is identical everywhere.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81769de2a849
Remove two addons from e10s allow list as they don't work. r=mconley

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8827262 [details]
Bug 1331308 - Remove two addons from e10s allow list as they don't work.

We should get this onto aurora and beta branches too. (It is usually best to keep mozilla-beta and m-r in sync)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0a98114d9a15

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81769de2a849