133136 - strict warnings

Status: RESOLVED WORKSFORME

(SeaMonkey :: UI Design, defect)

Description

[timeless]

Warning: trailing comma is not legal in ECMA-262 object initializers
Source 
File: chrome://communicator/content/contentAreaDD.js
Line: 83
Source Code:
};

Warning: function findAgainInPage does not always return a value
Source File: 
chrome://communicator/content/findUtils.js
Line: 106
Source Code:
}

Warning: anonymous function does not always return a value
Source File: 
chrome://communicator/content/bookmarks/bookmarksOverlay.js
Line: 862, Column: 
67
Source Code:
    return BMSvc.createFolderWithDetails(aTitle, aParentFolder, 
ix);

Warning: function OpenBookmarkGroup does not always return a value
Source File: 
chrome://navigator/content/navigator.js
Line: 632, Column: 65
Source Code:
  
return OpenBookmarkGroupFromResource(resource, datasource, rdf);

Warning: variable resource hides argument
Source File: 
chrome://navigator/content/navigator.js
Line: 644, Column: 8
Source Code:
    var 
resource = 
containerChildren.getNext().QueryInterface(Components.interfaces.nsIRDFResource
);

Warning: redeclaration of var tabs
Source File: 
chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 1267, Column: 10
Source Code:
      var tabs = sidebarObj.panels.node.childNodes;

Warning: redeclaration of var i
Source File: 
chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 1346, Column: 13
Source Code:
    for (var i = 2; i < tabs.length; i += 2)

Warning: redeclaration of var currHeader
Source File: 
chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 1348, Column: 10
Source Code:
      var currHeader = tabs[i];

Warning: redeclaration of var currTab
Source File: 
chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 1349, Column: 10
Source Code:
      var currTab = new sbPanel(currHeader.getAttribute("id"), 
currHeader, i);

Comment 1

[timeless]

Attachment: patch

Comment 2

[timeless]

plus this patch to fix the other bookmark bug
@@ -632 +632 @@
-  return OpenBookmarkGroupFromResource(resource, datasource, rdf);
+  OpenBookmarkGroupFromResource(resource, datasource, rdf);

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 75840 [details] [diff] [review]
patch

r=caillon

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

any news about this rotting patch? is it even needed anymore? timeless?

Comment 5

[timeless]

the changes appear to be in cvs