WebM alpha needs a reftest

RESOLVED FIXED in Firefox 53

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
3 months ago
a month ago

People

(Reporter: Karolien, Assigned: Karolien)

Tracking

unspecified
mozilla53
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

59 bytes, text/x-review-board-request
SingingTree
: review+
Details | Review
(Assignee)

Description

3 months ago
We need a way to check that WebM alpha is working. A ref test can indicate if the alpha channel is being rendered correctly.
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8827307 [details]
Bug 1331528 - Added reftest for WebM alpha.

https://reviewboard.mozilla.org/r/105026/#review105854

::: layout/reftests/webm-video/webm-alpha-ref.html:2
(Diff revision 1)
> +<!DOCTYPE HTML>
> +<html class="reftest-wait">

I think we can remove the wait class and the script here. The black page should be ready by the time the load event is fired (which prompts the harness to snapshot the page).

::: layout/reftests/webm-video/webm-alpha.html:2
(Diff revision 1)
> +<!DOCTYPE HTML>
> +<html class="reftest-wait">

It may be safe to remove the wait here depending on intended test behaviour. Based on the poster2 test (and looking through the spec) I think you can rely on that the test will have loaded enough data to display its video poster (an image to be shown before playing, or if no image is given then the first frame) by the time the harness snapshots.

If the video contains frames with the same content, and you don't need to start playback, you could remove the waits, and the on\* event handlers and rely on alpha being displayed correctly in the poster.

Comment 3

3 months ago
mozreview-review-reply
Comment on attachment 8827307 [details]
Bug 1331528 - Added reftest for WebM alpha.

https://reviewboard.mozilla.org/r/105026/#review105854

I recall there being something during development that may have prompted the adding of the waits to the tests. I've tested without the waits that I suggested could be removed, and appear to be getting desired behaviour (along with breakages if I change the video), but if I've overlooked something please let me know.
Comment hidden (mozreview-request)

Comment 5

3 months ago
mozreview-review
Comment on attachment 8827307 [details]
Bug 1331528 - Added reftest for WebM alpha.

https://reviewboard.mozilla.org/r/105026/#review106046

LGTM.
Attachment #8827307 - Flags: review?(bvandyk) → review+
(Assignee)

Comment 6

3 months ago
mozreview-review
Comment on attachment 8827307 [details]
Bug 1331528 - Added reftest for WebM alpha.

https://reviewboard.mozilla.org/r/105026/#review106048
(Assignee)

Updated

3 months ago
Assignee: nobody → kkoorts
(Assignee)

Updated

3 months ago
Keywords: checkin-needed

Comment 7

3 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/44b7d75e21e8
Added reftest for WebM alpha. r=SingingTree
Keywords: checkin-needed

Comment 8

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/44b7d75e21e8
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox53: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Updated

a month ago
Depends on: 1336872
You need to log in before you can comment on or make changes to this bug.