1331546 - Remove gleam gl ffi usages from offscreen_gl_context

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

offscreen_gl_context uses gl ffl functions. It is necessary to remove for Bug 1325911.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 2

[Emilio Cobos Álvarez (:emilio)]

As the author of that crate I'm happy to take that patch upstream with the unnecessary unsafe blocks removed (not sure if you planned to upstream it or not).

Thanks!

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #2)
> As the author of that crate I'm happy to take that patch upstream with the
> unnecessary unsafe blocks removed (not sure if you planned to upstream it or
> not).
> 
> Thanks!

Thanks for the feedback! I am thinking to upstream it.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Remove unnecessary unsafe blocks.

Comment 5

[Sotaro Ikeda [:sotaro]]

https://github.com/servo/gleam/pull/102

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Sotaro, FYI there's a better way to test changes to third_pary/rust than to manually update the checksums. I added a section to the wiki page at https://wiki.mozilla.org/Platform/GFX/Quantum_Render#Testing_third-party_rust_library_changes describing how to do it.

Comment 7

[Sotaro Ikeda [:sotaro]]

Thanks! It helps a lot:)

Comment 8

[Sotaro Ikeda [:sotaro]]

Emilio, can we get new version of gleam on crate.io? Is it necessary for pull request of offscreen_gl_context?

Comment 9

[Sotaro Ikeda [:sotaro]]

The following showed 'gleam = "0.2.30'. But the https://github.com/servo/gleam/pull/102 updated to "0.2.31'
  https://crates.io/crates/gleam

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Done, sorry, should've done it right after reviewing it.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

FWIW if this happens again, most of the servo people have access to publish crates, so asking on #servo uses to be an effective way of getting it published soon :)

Thanks again for this!

Comment 12

[Sotaro Ikeda [:sotaro]]

Thanks :)

Comment 13

[Sotaro Ikeda [:sotaro]]

https://github.com/emilio/rust-offscreen-rendering-context/pull/76