Closed Bug 1331554 Opened 3 years ago Closed 3 years ago

MediaFormatReader::SetBlankDecode() doesn't need to call ScheduleUpdate()

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(2 files)

http://searchfox.org/mozilla-central/rev/0aed9484bd3e97206fd1949ee4a4992ef300a81f/dom/media/MediaFormatReader.cpp#2733

ScheduleUpdate() causes the decoder to be created. We should as lazy as possible in creating decoders until there are new decoding requests which will schedule Update() loops if necessary.
Assignee: nobody → jwwang
Priority: -- → P3
Comment on attachment 8827337 [details]
Bug 1331554. Part 1 - print logs only when decoder.mIsBlankDecode is going to change.

https://reviewboard.mozilla.org/r/105048/#review106224

s/gonna/going to/
in commit log
Attachment #8827337 - Flags: review?(jyavenard) → review+
Comment on attachment 8827338 [details]
Bug 1331554. Part 2 - remove the call to ScheduleUpdate().

https://reviewboard.mozilla.org/r/105050/#review106226
Attachment #8827338 - Flags: review?(jyavenard) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7e15e279222
Part 1 - print logs only when decoder.mIsBlankDecode is going to change. r=jya
https://hg.mozilla.org/integration/autoland/rev/18f622aa877e
Part 2 - remove the call to ScheduleUpdate(). r=jya
https://hg.mozilla.org/mozilla-central/rev/f7e15e279222
https://hg.mozilla.org/mozilla-central/rev/18f622aa877e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.