1331554 - MediaFormatReader::SetBlankDecode() doesn't need to call ScheduleUpdate()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/0aed9484bd3e97206fd1949ee4a4992ef300a81f/dom/media/MediaFormatReader.cpp#2733

ScheduleUpdate() causes the decoder to be created. We should as lazy as possible in creating decoders until there are new decoding requests which will schedule Update() loops if necessary.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1331554. Part 1 - print logs only when decoder.mIsBlankDecode is going to change.

Review commit: https://reviewboard.mozilla.org/r/105048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105048/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1331554. Part 2 - remove the call to ScheduleUpdate().

ScheduleUpdate() will be called when we have new decoding requests.

Review commit: https://reviewboard.mozilla.org/r/105050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105050/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8827337 [details]
Bug 1331554. Part 1 - print logs only when decoder.mIsBlankDecode is going to change.

https://reviewboard.mozilla.org/r/105048/#review106224

s/gonna/going to/
in commit log

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8827338 [details]
Bug 1331554. Part 2 - remove the call to ScheduleUpdate().

https://reviewboard.mozilla.org/r/105050/#review106226

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8827337 [details]
Bug 1331554. Part 1 - print logs only when decoder.mIsBlankDecode is going to change.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105048/diff/1-2/

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8827338 [details]
Bug 1331554. Part 2 - remove the call to ScheduleUpdate().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105050/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7e15e279222
Part 1 - print logs only when decoder.mIsBlankDecode is going to change. r=jya
https://hg.mozilla.org/integration/autoland/rev/18f622aa877e
Part 2 - remove the call to ScheduleUpdate(). r=jya

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f7e15e279222
https://hg.mozilla.org/mozilla-central/rev/18f622aa877e