Open
Bug 1331558
Opened 8 years ago
Updated 2 years ago
Migrate existing z-index Inspector into m-c
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(Not tracked)
NEW
People
(Reporter: gl, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
59.71 KB,
patch
|
gregtatum
:
review+
|
Details | Diff | Splinter Review |
To facilitate the work of getting the z-index inspector to work inside the toolbox, we need to migrate the current existing codebase from https://github.com/gregtatum/z-index-devtool into m-c.
We will migrate the code as-is from github, and subsequent bugs will modify the requires, and add the necessary build files to ensure the code can build correctly. This is mainly to reduce the review overhead.
Reporter | ||
Comment 1•8 years ago
|
||
Attachment #8827347 -
Flags: review?(gtatum)
Comment 2•8 years ago
|
||
Comment on attachment 8827347 [details] [diff] [review]
1331558.patch
Review of attachment 8827347 [details] [diff] [review]:
-----------------------------------------------------------------
I'm a little nervous of committing the code as-is, but I guess it makes sense from a review and migration perspective. I'll leave it up to your judgement. I would just ask that the commit message be very detailed with the reasoning and include a link to the original repo. What does linting look like with these additions?
::: devtools/client/inspector/zindex/components/tree.js
@@ +1,1 @@
> +/* This Source Code Form is subject to the terms of the Mozilla Public
This file is a duplicate of devtools/client/shared/components/tree.js so it probably shouldn't be checked in.
Attachment #8827347 -
Flags: review?(gtatum) → review+
Updated•7 years ago
|
Product: Firefox → DevTools
Reporter | ||
Updated•7 years ago
|
Assignee: gl → nobody
Status: ASSIGNED → NEW
Updated•3 years ago
|
Type: defect → enhancement
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•