Open Bug 1331558 Opened 7 years ago Updated 2 years ago

Migrate existing z-index Inspector into m-c

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: gl, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

To facilitate the work of getting the z-index inspector to work inside the toolbox, we need to migrate the current existing codebase from https://github.com/gregtatum/z-index-devtool into m-c. 

We will migrate the code as-is from github, and subsequent bugs will modify the requires, and add the necessary build files to ensure the code can build correctly. This is mainly to reduce the review overhead.
Attached patch 1331558.patchSplinter Review
Attachment #8827347 - Flags: review?(gtatum)
Comment on attachment 8827347 [details] [diff] [review]
1331558.patch

Review of attachment 8827347 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little nervous of committing the code as-is, but I guess it makes sense from a review and migration perspective. I'll leave it up to your judgement. I would just ask that the commit message be very detailed with the reasoning and include a link to the original repo. What does linting look like with these additions?

::: devtools/client/inspector/zindex/components/tree.js
@@ +1,1 @@
> +/* This Source Code Form is subject to the terms of the Mozilla Public

This file is a duplicate of devtools/client/shared/components/tree.js so it probably shouldn't be checked in.
Attachment #8827347 - Flags: review?(gtatum) → review+
Product: Firefox → DevTools
Assignee: gl → nobody
Status: ASSIGNED → NEW
Type: defect → enhancement
See Also: → 659807
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: