Closed Bug 1331571 Opened 4 years ago Closed 4 years ago

Remove Intel Power Gadget integration from the profiler

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(1 file)

Remove Intel Power Gadget integration from the compiler
22.75 KB, patch
mstange
: review+
Details | Diff | Splinter Review 
I'm pretty sure nobody has ever used this. I didn't even when I was working on Project Candle and actively investigating power consumption in Firefox. As https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Power_profiling_overview says:

> observations made during power profiling — even more than with other kinds of
> profiling — can disturb what is being observed. For example, the Gecko
> Profiler takes samples at 1000Hz using a timer. Each of these samples can
> trigger a wakeup, which consumes power and obscures Firefox's natural wakeup
> patterns. For this reason, integrating power measurements into the Gecko
> Profiler is unlikely to be useful, and other power profiling tools typically
> use much lower sampling rates (e.g. 1Hz.)

Let's just remove the code.
Nobody has ever used this, and measuring power consumption while running a
sampling profiler at 1000 Hz isn't a good idea.
Attachment #8827364 - Flags: review?(mstange)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Bug 769431 added this code, FWIW.
It's possible that Cleopatra should be updated as well.
Comment on attachment 8827364 [details] [diff] [review]
Remove Intel Power Gadget integration from the compiler

Review of attachment 8827364 [details] [diff] [review]:
-----------------------------------------------------------------

You missed some stuff in ProfileEntry.cpp: mPower, POWER, and the 'p' profile buffer entries.
Attachment #8827364 - Flags: review?(mstange) → review+
Whoops, this bug and commit should have said "profiler" instead of "compiler". Oh well.
Summary: Remove Intel Power Gadget integration from the compiler → Remove Intel Power Gadget integration from the profiler
https://hg.mozilla.org/mozilla-central/rev/7a0ca4bad5c3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.