Remove Intel Power Gadget integration from the profiler

RESOLVED FIXED in Firefox 53

Status

()

Core
Gecko Profiler
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
I'm pretty sure nobody has ever used this. I didn't even when I was working on Project Candle and actively investigating power consumption in Firefox. As https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Power_profiling_overview says:

> observations made during power profiling — even more than with other kinds of
> profiling — can disturb what is being observed. For example, the Gecko
> Profiler takes samples at 1000Hz using a timer. Each of these samples can
> trigger a wakeup, which consumes power and obscures Firefox's natural wakeup
> patterns. For this reason, integrating power measurements into the Gecko
> Profiler is unlikely to be useful, and other power profiling tools typically
> use much lower sampling rates (e.g. 1Hz.)

Let's just remove the code.
(Assignee)

Comment 1

7 months ago
Created attachment 8827364 [details] [diff] [review]
Remove Intel Power Gadget integration from the compiler

Nobody has ever used this, and measuring power consumption while running a
sampling profiler at 1000 Hz isn't a good idea.
Attachment #8827364 - Flags: review?(mstange)
(Assignee)

Updated

7 months ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 2

7 months ago
Bug 769431 added this code, FWIW.
(Assignee)

Comment 3

7 months ago
It's possible that Cleopatra should be updated as well.
(Assignee)

Updated

7 months ago
Blocks: 1328363
Comment on attachment 8827364 [details] [diff] [review]
Remove Intel Power Gadget integration from the compiler

Review of attachment 8827364 [details] [diff] [review]:
-----------------------------------------------------------------

You missed some stuff in ProfileEntry.cpp: mPower, POWER, and the 'p' profile buffer entries.
Attachment #8827364 - Flags: review?(mstange) → review+
(Assignee)

Comment 5

7 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a0ca4bad5c3449b4f0ee22d66bc051f40f044fb
Bug 1331571 - Remove Intel Power Gadget integration from the compiler. r=mstange.
(Assignee)

Comment 6

7 months ago
Whoops, this bug and commit should have said "profiler" instead of "compiler". Oh well.
Summary: Remove Intel Power Gadget integration from the compiler → Remove Intel Power Gadget integration from the profiler

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7a0ca4bad5c3
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.