Closed
Bug 1331581
Opened 8 years ago
Closed 8 years ago
Clean up nsMediaFeatureValueGetter
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
|
11.38 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
It always returns NS_OK.
|
Assignee | |
Comment 1•8 years ago
|
||
Doing only a Gecko patch to avoid the churn of submitting a unified patch here, then splitting them, and push both separately. The servo-side change is trivial.
|
|
Assignee | |
Comment 2•8 years ago
|
||
There are two `return MakeArray(..)` that I've also removed locally since they're not needed now.
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8827897 [details] [diff] [review]
patch
Review of attachment 8827897 [details] [diff] [review]:
-----------------------------------------------------------------
r=me but I'm not sure what you mean by the unneeded MakeArray calls, since it seems they're still needed even once you change them to return void?
Attachment #8827897 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
I meant the |return| keyword was unneeded now, sorry, should've been clearer.
|
|
Assignee | |
Comment 5•8 years ago
|
||
The push bot is down apparently: https://hg.mozilla.org/integration/mozilla-inbound/rev/52a8ae1e1a82
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•