Closed Bug 1331581 Opened 3 years ago Closed 3 years ago

Clean up nsMediaFeatureValueGetter

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

It always returns NS_OK.
Attached patch patchSplinter Review
Doing only a Gecko patch to avoid the churn of submitting a unified patch here, then splitting them, and push both separately. The servo-side change is trivial.
Assignee: nobody → emilio+bugs
Status: NEW → ASSIGNED
Attachment #8827897 - Flags: review?(cam)
There are two `return MakeArray(..)` that I've also removed locally since they're not needed now.
Comment on attachment 8827897 [details] [diff] [review]
patch

Review of attachment 8827897 [details] [diff] [review]:
-----------------------------------------------------------------

r=me but I'm not sure what you mean by the unneeded MakeArray calls, since it seems they're still needed even once you change them to return void?
Attachment #8827897 - Flags: review?(cam) → review+
I meant the |return| keyword was unneeded now, sorry, should've been clearer.
https://hg.mozilla.org/mozilla-central/rev/52a8ae1e1a82
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.