Closed Bug 1331584 Opened 5 years ago Closed 5 years ago

stylo: Get the proper viewport size for viewport units evaluation

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1303229

People

(Reporter: emilio, Unassigned)

References

Details

We use to pass a fake viewport size to the cascade() function. That's used for viewport units.

With the work in bug 1331213, the missing piece for this is a binding function that takes it from the pres context.

Note we need to take into account scrollbars on some cases, so we should do something similar to what CalcViewportUnitsScale[1] does, checking it's thread safe.

[1]: http://searchfox.org/mozilla-central/rev/c477aa8bd99278962998adba1c5e4b15a02c42c7/layout/style/nsRuleNode.cpp#398
Sorry, I don't know how to write, sigh.
Summary: stylo: Get the proper viewport size for media query evaluation → stylo: Get the proper viewport size for viewport units evaluation
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1303229
You need to log in before you can comment on or make changes to this bug.