Closed
Bug 1331706
Opened 8 years ago
Closed 8 years ago
Consider making vsync non-prioritized in Aurora
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | fixed |
firefox53 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
682 bytes,
patch
|
billm
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Our animation code is too slow (bug 1322970) and looks like we have some other slow (and otherwise buggy, based on the leak) code too (bug 1329079) and those bugs possibly can't be fixed in Aurora
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → bugs
Assignee | ||
Updated•8 years ago
|
Attachment #8827585 -
Flags: review?(wmccloskey)
Attachment #8827585 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8827585 [details] [diff] [review]
non_prio_vsync.diff
Approval Request Comment
[Feature/Bug causing the regression]: bug 1306591
[User impact if declined]: slowly behaving web pages in some case
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: this is disabling a feature causing regressions
[Needs manual test from QE? If yes, steps to reproduce]: See the blocking bugs and test cases in them
[List of other uplifts needed for the feature/fix]: NA
[Is the change risky?]: not
[Why is the change risky/not risky?]: we're just reverting back to the old behavior
[String changes made/needed]: NA
Attachment #8827585 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 3•8 years ago
|
||
Another testcase https://jsfiddle.net/va5vpxLz/1/
Comment 4•8 years ago
|
||
Comment on attachment 8827585 [details] [diff] [review]
non_prio_vsync.diff
no priority for vsync event, aurora52+
Attachment #8827585 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 5•8 years ago
|
||
bugherder uplift |
status-firefox52:
--- → fixed
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → unaffected
status-firefox53:
--- → wontfix
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee | ||
Comment 6•8 years ago
|
||
Hmm, I thought I had landed this to m-i too, since I want this to the next aurora.
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cded9d87d13
Make vsync non-prioritized for now. r=billm
Assignee | ||
Comment 8•8 years ago
|
||
Sorry if this way of landing causes any problems.
I'll back this out from m-i once I have good plan for bug 1332226 .
Comment 9•8 years ago
|
||
bugherder |
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•