1331719 - Fix building libpurple on Windows with MSVC 2015

Status: RESOLVED WONTFIX

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

Attachment: Patch v1

Libpurple fixes for Microsoft Visual Studio 2015.

Comment 1

[Patrick Cloke [:clokep]]

Comment on attachment 8827603 [details] [diff] [review]
Patch v1

Review of attachment 8827603 [details] [diff] [review]:
-----------------------------------------------------------------

::: libpurple/protocols/oscar/oscar.c
@@ -1912,5 @@
>  					tm = localtime(&now);
>  					t += tm->tm_gmtoff;
>  #else
>  #	ifdef HAVE_TIMEZONE
> -					tzset();

I'm not actually 100% sure this one is necessary. I'll need to try on my Windows machine again.

Comment 2

[aleth [:aleth]]

Comment on attachment 8827603 [details] [diff] [review]
Patch v1

Review of attachment 8827603 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable, but I don't understand the change you flagged in the previous comment, so I'll leave this for flo.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8827603 [details] [diff] [review]
Patch v1

Review of attachment 8827603 [details] [diff] [review]:
-----------------------------------------------------------------

::: libpurple/protocols/oscar/oscar.c
@@ +1912,5 @@
>  					tm = localtime(&now);
>  					t += tm->tm_gmtoff;
>  #else
>  #	ifdef HAVE_TIMEZONE
> +					_tzset();

Are we sure ifndef HAVE_TM_GMTOFF && ifdef HAVE_TIMEZONE matches only Windows?

Could/should we handle this change using #define in libpurple/win32/libc_interface.h to match what has been done for other symbols?