Closed Bug 1331719 Opened 3 years ago Closed 3 years ago

Fix building libpurple on Windows with MSVC 2015

Categories

(Chat Core :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: clokep, Assigned: clokep)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
Libpurple fixes for Microsoft Visual Studio 2015.
Attachment #8827603 - Flags: review?(florian)
Attachment #8827603 - Flags: review?(aleth)
Comment on attachment 8827603 [details] [diff] [review]
Patch v1

Review of attachment 8827603 [details] [diff] [review]:
-----------------------------------------------------------------

::: libpurple/protocols/oscar/oscar.c
@@ -1912,5 @@
>  					tm = localtime(&now);
>  					t += tm->tm_gmtoff;
>  #else
>  #	ifdef HAVE_TIMEZONE
> -					tzset();

I'm not actually 100% sure this one is necessary. I'll need to try on my Windows machine again.
Comment on attachment 8827603 [details] [diff] [review]
Patch v1

Review of attachment 8827603 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable, but I don't understand the change you flagged in the previous comment, so I'll leave this for flo.
Attachment #8827603 - Flags: review?(aleth)
Comment on attachment 8827603 [details] [diff] [review]
Patch v1

Review of attachment 8827603 [details] [diff] [review]:
-----------------------------------------------------------------

::: libpurple/protocols/oscar/oscar.c
@@ +1912,5 @@
>  					tm = localtime(&now);
>  					t += tm->tm_gmtoff;
>  #else
>  #	ifdef HAVE_TIMEZONE
> +					_tzset();

Are we sure ifndef HAVE_TM_GMTOFF && ifdef HAVE_TIMEZONE matches only Windows?

Could/should we handle this change using #define in libpurple/win32/libc_interface.h to match what has been done for other symbols?
Attachment #8827603 - Flags: review?(florian)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.